Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug new cloudavenue publicip return wrong public ip #389

Merged
merged 2 commits into from
Jul 18, 2023
Merged

fix: bug new cloudavenue publicip return wrong public ip #389

merged 2 commits into from
Jul 18, 2023

Conversation

dmicheneau
Copy link
Member

Description of your changes

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

TF_ACC=1 go test -v -count=1 -timeout 600m /Users/micheneaudavid/go/src/github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/tests/publicip/publicip_resource_test.go
=== RUN   TestAccPublicIPResource
--- PASS: TestAccPublicIPResource (112.97s)
PASS
ok      command-line-arguments  113.283s

@dmicheneau dmicheneau linked an issue Jul 18, 2023 that may be closed by this pull request
[Bug]: New cloudavenue_publicip return wrong public ip #386
Closed
@dmicheneau dmicheneau force-pushed the 386-bug-new-cloudavenue_publicip-return-wrong-public-ip branch from 2ce66bf to 4bb63b1 Compare July 18, 2023 14:05
@dmicheneau dmicheneau merged commit 3a8cdcc into main Jul 18, 2023
3 checks passed
@dmicheneau dmicheneau deleted the 386-bug-new-cloudavenue_publicip-return-wrong-public-ip branch July 18, 2023 14:07
dmicheneau pushed a commit that referenced this pull request Jul 18, 2023
chore: Add change file for bug fix #389
bc50fec
dmicheneau added a commit that referenced this pull request Jul 18, 2023
@dmicheneau
chore: Add change file for bug fix #389 (#391)
b6493a3 
Co-authored-by: David MICHENEAU <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azrod azrod azrod approved these changes

Assignees
No one assigned
Labels
Fix size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: New cloudavenue_publicip return wrong public ip
2 participants
@dmicheneau @azrod