Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to image_transport to allow compressed images + fix deadlock #202

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ArendJan
Copy link

I've changed the publishers to image_transport::publisher, to allow for compressed image transport to save bandwidth.

It works on my Orange Pi 3B running Armbian with ROS noetic and a Astra Pro Plus camera.

@ArendJan ArendJan changed the title Change to image_transport for compressed images Change to image_transport to allow compressed images May 21, 2024
@ArendJan
Copy link
Author

Also fixes deadlock in the UVCCameraDriver::frameCallback when unsubscribing the last subscriber:
The uvc_stop_streaming call would wait for the frameCallback, which is waiting on the device_lock_, held by the imageUnsubscribedCallback (waiting on uvc_stop_streaming)

@ArendJan ArendJan changed the title Change to image_transport to allow compressed images Change to image_transport to allow compressed images + fix deadlock Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant