This repository has been archived by the owner on Sep 30, 2023. It is now read-only.
new benchmarker/benchmarks; keeps old benchmarks #329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphelionz
approved these changes
May 31, 2021
| @@ -51,7 +51,7 @@ | |||
| "mocha": "^8.4.0", | |||
| "mocha-headless-chrome": "^3.1.0", | |||
| "nyc": "^15.0.1", | |||
| "orbit-db-benchmark-runner": "^1.0.3", | |||
| "orbit-db-benchmark-runner": "github:tabcat/benchmark-runner#benchmarker", | |||
There was a problem hiding this comment.
I suppose it's ok to publish a new version of the bechmark runner at this point?
There was a problem hiding this comment.
I published [email protected] so you can use that here.
aphelionz
suggested changes
May 31, 2021
|
We should probably remove the call to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds/updates benchmarks and an npm script to use the new benchmarker.
i decided not the do anything with the old benchmark files yet but we can add that as part of the pr if decided.
related: orbitdb-archive/benchmark-runner#32