Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get involved page 3 roadmap/ memorandum UI #114

Merged
merged 29 commits into from
Oct 17, 2023
Merged

Get involved page 3 roadmap/ memorandum UI #114

merged 29 commits into from
Oct 17, 2023

Conversation

NayoBaez
Copy link
Collaborator

Get Involved Page
Assigned issues: #48 & #108

  • Added all included links to text & buttons
  • Double checked all instances of "Orcasound"
  • Provided controls to allow user to zoom in / out / reset image
  • Made responsive to desktop / tablet & mobile as in Figma Design

NayoBaez and others added 16 commits March 24, 2023 14:12
@netlify
Copy link

netlify bot commented Apr 28, 2023 •
edited
Loading

✅ Deploy Preview for orcahome ready!

Name Link
🔨 Latest commit a1144cb
🔍 Latest deploy log https://app.netlify.com/sites/orcahome/deploys/652ecf393483ed0008beb19c
😎 Deploy Preview https://deploy-preview-114--orcahome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NayoBaez NayoBaez closed this May 23, 2023
@NayoBaez NayoBaez reopened this May 23, 2023
@JacobYLiu
Copy link

@evanjscallan We finished fixing the checks on this pull request as well.

evanjscallan
evanjscallan reviewed Jun 1, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
evanjscallan
evanjscallan reviewed Jun 1, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
evanjscallan
evanjscallan suggested changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@evanjscallan evanjscallan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@NayoBaez NayoBaez self-assigned this Sep 14, 2023
@UXBrendan
Copy link

@UXBrendan

Deploy preview passes UI check. 😎

@scottveirs scottveirs enabled auto-merge (squash) October 17, 2023 18:14
@scottveirs scottveirs disabled auto-merge October 17, 2023 18:15
scottveirs
scottveirs approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@scottveirs scottveirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for responding to Evan's feedback. Looks good to the oceanographer!

@UXBrendan UXBrendan self-requested a review October 17, 2023 18:20
UXBrendan
UXBrendan approved these changes Oct 17, 2023
View reviewed changes
Copy link

@UXBrendan UXBrendan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was told everything looks good and ready for approval.

@scottveirs scottveirs merged commit 2b8283a into orcasound:main Oct 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanjscallan evanjscallan evanjscallan requested changes

@UXBrendan UXBrendan UXBrendan approved these changes

@scottveirs scottveirs scottveirs approved these changes

Assignees

@NayoBaez NayoBaez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NayoBaez @JacobYLiu @UXBrendan @scottveirs @evanjscallan