Add Stylelint and a reasonable configuration, and bring SASS/SCSS up-to-spec #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ope, this is a duplicate of #534 -- feel free to disregard this PR, but please consider merging either this one or that one at some point... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team!
I was getting a Stylelint warning from the
tom-selectSASS/SCSS in our codebase. The SASS linter can either continue to warn or turn off all warnings for dependencies, and I wasn't satisfied by that latter option, so I thought I'd bring some linty goodness into thetom-selectrepository.I've added
stylelintand its SASS compatibility to the dev dependencies, added a minimal configuration for it that balances ignoring things that aren't worth refactoring for, and made edits to the SCSS files to bring them into spec with the linter.I don't believe I have functionally changed anything, but you never know! I ran the doc/demo site via
npm startand everything seems to be behaving itself...Most tests pass, a few do not but they do not seem related to this change!