Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes 2 problems:
ShellExecReq
property name should becommand
and notcmd
. The latter worked because of the way GSON worked in Java, but now we have fixed the naming in Java and so the corresponding Julia message needed update.GenericMessage
had a bug, causing printing ofGenericMessages
to throw exceptions. We now have a better iterator.What was broken
This was failing with a
REFUSE
:and this was not allowed:
With
cmd
replaced bycommand
in the message definition, this worked:but this was failing with an exception:
All of this works after this PR!