-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect Redirect Articles #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
newsch
commented
Sep 26, 2023
•
edited
Loading
edited
- Parse redirect tags from articles
- Add test cases
- Handle empty articles nicely
- Check results with all problem articles
newsch
force-pushed
the
detect-redirect-articles
branch
from
September 29, 2023 20:11
81e6ad9
to
4cf55a3
Compare
biodranik
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will test it on the server.
@newsch let's finish this one! |
👍 I have some time this week to work on it.
|
Signed-off-by: Evan Lloyd New-Schmidt <[email protected]>
Signed-off-by: Evan Lloyd New-Schmidt <[email protected]>
Signed-off-by: Evan Lloyd New-Schmidt <[email protected]>
I've seen a 10-20% speedup on larger articles. Signed-off-by: Evan Lloyd New-Schmidt <[email protected]>
Signed-off-by: Evan Lloyd New-Schmidt <[email protected]>
Signed-off-by: Evan Lloyd New-Schmidt <[email protected]>
Signed-off-by: Evan Lloyd New-Schmidt <[email protected]>
Signed-off-by: Evan Lloyd New-Schmidt <[email protected]>
newsch
force-pushed
the
detect-redirect-articles
branch
from
January 24, 2024 20:37
559361f
to
d52c330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.