Reset all panel state when /run_id changes

[amacneil]

via @jhurliman:

We can detect when the robot has been torn down and restarted (vs a network disconnect/reconnect) by monitoring the /run_id parameter in Ros1Player. When this changes, all panel state should be cleared so the user doesn't see a mixture of old and new session state in panels like the watchdog monitor, timeline chart, 3D view markers, etc.

[wkalt]

@amacneil @jhurliman I think a user can easily hit this in our onboarding flow. They will initially load the welcome screen with the demo bag data, and then the first time they try to use their own bag they will see mixed state, unless the new set of topics matches what was previously displayed.

[amacneil]

agreed, let's prioritize this since it affects new users

[jtbandes]

That doesn't sound right - loading their own bag will be swapping out a data source, since the demo bag is a separate HTTP bag. This issue only affects you if you're using a ROS/WebSocket connection and tearing down/launching nodes without restarting the ros master.

[amacneil]

Related: reset panel state when player changes https://github.com/foxglove/studio/pull/1008

[github-actions[bot]]

This issue is being marked as stale because there has been no activity for 180 days. Please add a comment to keep it open.

[amacneil]

@jhurliman is this still relevant?

[jhurliman]

Yes it is

[github-actions[bot]]

This issue has been marked as stale because there has been no activity in the past 6 months. Please add a comment to keep it open.