Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot like tweet #48

Merged
merged 3 commits into from
May 24, 2021
Merged

fix: cannot like tweet #48

merged 3 commits into from
May 24, 2021

Conversation

orimdominic
Copy link
Owner

@orimdominic orimdominic commented May 24, 2021

Description

Fixes inability to like tweet

Points worth noting

Inability to like tweets was caused by a problem with the library used
I created an issue on it at twitter-lite issue 169

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

e2e

  • Unit test
  • Integration test

Checklist:

  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented May 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sudo-kaizen/pick-at-random/7rZdDXPNrKriSKjk2Y5Meq4RvTYx
✅ Preview: https://pick-at-random-git-fix-cannot-like-tweet-sudo-kaizen.vercel.app

@codecov-commenter
Copy link

Codecov Report

Merging #48 (99daae7) into main (21aa1fe) will decrease coverage by 0.28%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   79.85%   79.56%   -0.29%     
==========================================
  Files          13       13              
  Lines         278      279       +1     
  Branches       32       32              
==========================================
  Hits          222      222              
  Misses         46       46              
- Partials       10       11       +1     
Impacted Files Coverage Δ
api/twitter-webhook-listener.ts 57.89% <ø> (-2.11%) ⬇️
src/par-activity/cache.ts 66.66% <ø> (ø)
src/par-activity/handle-tweet-create.ts 30.30% <ø> (ø)
src/par-activity/par-twitter-client.ts 50.00% <44.44%> (+12.50%) ⬆️
src/par-activity/time-parser.ts 77.27% <0.00%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21aa1fe...99daae7. Read the comment docs.

@orimdominic orimdominic merged commit 91b47d5 into main May 24, 2021
@orimdominic orimdominic deleted the fix/cannot-like-tweet branch May 24, 2021 01:31
@orimdominic
Copy link
Owner Author

Related to #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants