Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support android webauthn origins #4155

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat: support android webauthn origins #4155

wants to merge 8 commits into from

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 11, 2024

This patch adds the ability to verify Android APK origins used during WebAuthn/Passkey exchange.

Upgrades go-webauthn and includes fixes for Go 1.23.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr force-pushed the android-sdk branch 2 times, most recently from 9cc2f51 to 53b22c9 Compare October 13, 2024 07:29
@aeneasr aeneasr marked this pull request as ready for review October 13, 2024 08:09
@aeneasr aeneasr force-pushed the android-sdk branch 4 times, most recently from 1223fb0 to 62cb9e9 Compare October 14, 2024 07:25
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (f9640ff) to head (cfc6cd6).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
identity/credentials_webauthn.go 80.00% 6 Missing and 1 partial ⚠️
schema/handler.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4155      +/-   ##
==========================================
- Coverage   78.56%   78.56%   -0.01%     
==========================================
  Files         379      379              
  Lines       27032    27065      +33     
==========================================
+ Hits        21239    21263      +24     
- Misses       4181     4190       +9     
  Partials     1612     1612              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

identity/credentials_webauthn.go Show resolved Hide resolved
identity/credentials_webauthn.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants