Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Verific Front End #484

Merged
merged 13 commits into from
Sep 23, 2023
Merged

Disable Verific Front End #484

merged 13 commits into from
Sep 23, 2023

Conversation

nadeemyaseen-rs
Copy link
Contributor

No description provided.

@alain-rs
Copy link
Contributor

@awaisabbas-rs @nadeemyaseen-rs , any progress here?

@awaisabbas-rs
Copy link
Contributor

Hi @alain-rs I'm fixing the CI which breaks after disabling verific, I will create the PR ASAP for CI fix

@nadeemyaseen-rs nadeemyaseen-rs marked this pull request as ready for review September 22, 2023 09:09
@nadeemyaseen-rs
Copy link
Contributor Author

@alain-rs This PR is ready to merge.

thierryBesson
thierryBesson reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@thierryBesson thierryBesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nadeemyaseen-rs , as far as I see your implementation makes a potential way back to Verific straightforward (we simply play on ENABLE_VERIFIC and YOSYS_VERIFIC). Is that correct or it is more complicated than that ?

@nadeemyaseen-rs
Copy link
Contributor Author

Hi @nadeemyaseen-rs , as far as I see your implementation makes a potential way back to Verific straightforward (we simply play on ENABLE_VERIFIC and YOSYS_VERIFIC). Is that correct or it is more complicated than that ?

Yes, it is correct. along with adding Verifc again as a submodule. .. Even going back in git history, we can get the verific running.

thierryBesson
thierryBesson approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@thierryBesson thierryBesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok perfect. Thanks.

@alain-rs alain-rs merged commit 74b7f31 into main Sep 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thierryBesson thierryBesson thierryBesson approved these changes

@alain-rs alain-rs Awaiting requested review from alain-rs

Assignees

@awaisabbas-rs awaisabbas-rs

@ayyazahmed-rs ayyazahmed-rs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nadeemyaseen-rs @alain-rs @awaisabbas-rs @thierryBesson @ayyazahmed-rs @behzadmehmood-rs @alaindargelas