-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synthesis QoR Infra updated #495
Conversation
@komalinayat newly added bram and dsp designs are failing, can you please look why and fix them in this branch |
Hi @thierryBesson with the changes that have been made, 263 out of 283 from golden suite designs passed through. If CI succeed we can merge this branch into main. |
I will look into it. |
@komalinayat we have 20 failures, out of which ~10 designs can pass by changing the front-end from verilog to system verilog, e.g bch_configurable_bm etc. Please looking into CGA results how they handled those designs and replicate it here. Meanwhile @thierryBesson you can use the current implementation with 93% pass rate. |
@@ -370,7 +440,7 @@ def run_benchmark_with_vivado(benchmark, vivado_file_template, | |||
logger.error('Failed to execute synthesis of {0} for configuration ' | |||
'{1}:\n {2}'.format(benchmark["name"], cfg_name, | |||
traceback.format_exc())) | |||
|
|||
#### DIAMOND |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this line and line 464 as I initially included them to distinguish between Yosys, and diamond during my work, but these are unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Komal, Ok, remove these comments when you will submit the PR for 20 failing designs. for now i'm merging th PR
No description provided.