Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthesis QoR Infra updated #495

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Synthesis QoR Infra updated #495

merged 5 commits into from
Oct 11, 2023

Conversation

awaisabbas-rs
Copy link
Contributor

No description provided.

@awaisabbas-rs
Copy link
Contributor Author

@komalinayat newly added bram and dsp designs are failing, can you please look why and fix them in this branch

@awaisabbas-rs
Copy link
Contributor Author

Hi @thierryBesson with the changes that have been made, 263 out of 283 from golden suite designs passed through. If CI succeed we can merge this branch into main.

@komalinayat
Copy link
Contributor

I will look into it.

@awaisabbas-rs
Copy link
Contributor Author

awaisabbas-rs commented Oct 11, 2023

@komalinayat we have 20 failures, out of which ~10 designs can pass by changing the front-end from verilog to system verilog, e.g bch_configurable_bm etc. Please looking into CGA results how they handled those designs and replicate it here.

Meanwhile @thierryBesson you can use the current implementation with 93% pass rate.

@@ -370,7 +440,7 @@ def run_benchmark_with_vivado(benchmark, vivado_file_template,
logger.error('Failed to execute synthesis of {0} for configuration '
'{1}:\n {2}'.format(benchmark["name"], cfg_name,
traceback.format_exc()))

#### DIAMOND
Copy link
Contributor

@komalinayat komalinayat Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this line and line 464 as I initially included them to distinguish between Yosys, and diamond during my work, but these are unnecessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Komal, Ok, remove these comments when you will submit the PR for 20 failing designs. for now i'm merging th PR

@awaisabbas-rs awaisabbas-rs merged commit 6dcdf62 into main Oct 11, 2023
6 checks passed
@awaisabbas-rs awaisabbas-rs deleted the qor_infra branch October 12, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants