Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdrgn: improve C string reading efficiency #313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

libdrgn: improve C string reading efficiency #313

wants to merge 1 commit into from

Commits on Jul 8, 2023

  1. libdrgn: improve C string reading efficiency 

    The current C string reading implementation is inefficient, especially for
low bandwidth remote targets, as it needs to do a separate segment read
(including a fresh page table lookup) for each character read. A more
efficient approach is to retain the page table between character reads,
only discarding it when we hit the null terminator.

Implement this approach by allowing segments to also specify a C string
reading callback. The callback for page tables will preserve the page
table iterator while reading characters.

Signed-off-by: Peter Collingbourne <[email protected]>
    @pcc
    pcc committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    ad47114 View commit details
    Browse the repository at this point in the history