Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GAP_pkg_juliainterface_jll #1139

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

fingolfin
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.53%. Comparing base (0f83ffd) to head (bd3cd82).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
- Coverage   82.74%   74.53%   -8.21%     
==========================================
  Files          50       55       +5     
  Lines        3824     4716     +892     
==========================================
+ Hits         3164     3515     +351     
- Misses        660     1201     +541     

see 9 files with indirect coverage changes

lgoettgens
lgoettgens previously approved these changes Feb 3, 2025
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ctbllib CI job has a segfault, but that should be unrelated to this change.

@fingolfin
Copy link
Member Author

@lgoettgens what confuses me are the failures in Julia nightly which again report worldage failures. I wonder if that means something went wrong compiling the JLL that caused it to no pick up JULIA_VERSION_MINOR and JULIA_VERSION_MAJOR correctly... huh

@lgoettgens
Copy link
Member

Indeed, the scheduled CI from this morning (https://github.com/oscar-system/GAP.jl/actions/runs/13105678001/job/36560073838) was completely green, with only the world-age warnings from Documenter. So in some sense, this change makes it worse than before.

@fingolfin
Copy link
Member Author

I can reproduce this locally so it is not something weird in the CI.

But I also used a disassembler to look at the JuliaInterface.so in the JLL -- and thus verified that its Func_JuliaGetGlobalVariableByModule really does contain the new code which updates the world age.

However comparing it with a locally built JuliaInterface.so it appears the offset to world age is different. Conclusion: libjulia_jll needs to be updated with a recent Julia master snapshot, then we can rebuild GAP_pkg_juliainterface_jll and hopefully it'll work as desired.

@lgoettgens lgoettgens closed this Feb 4, 2025
@lgoettgens lgoettgens reopened this Feb 4, 2025
@lgoettgens
Copy link
Member

julia nightly now refers to 1.13-DEV, for which we don't have a libjulia yet (x-ref JuliaPackaging/Yggdrasil#10429). After #1141 is merged, we can at least see CI running on 1.12-DEV again.

@lgoettgens
Copy link
Member

The 1.12 tests only show warnings about docmeta, i.e. JuliaDocs/Documenter.jl#2621.

I am looking into the 1.13 failure, this probably has to do with Aqua.jl.

@lgoettgens lgoettgens closed this Feb 6, 2025
@lgoettgens lgoettgens reopened this Feb 6, 2025
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now.
Two things to note:

@fingolfin fingolfin enabled auto-merge (squash) February 6, 2025 15:19
@fingolfin fingolfin merged commit 9be5ed5 into master Feb 6, 2025
334 of 340 checks passed
@fingolfin fingolfin deleted the mh/update-GAP_pkg_juliainterface_jll branch February 6, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants