-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GAP_pkg_juliainterface_jll #1139
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1139 +/- ##
==========================================
- Coverage 82.74% 74.53% -8.21%
==========================================
Files 50 55 +5
Lines 3824 4716 +892
==========================================
+ Hits 3164 3515 +351
- Misses 660 1201 +541 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ctbllib
CI job has a segfault, but that should be unrelated to this change.
@lgoettgens what confuses me are the failures in Julia nightly which again report worldage failures. I wonder if that means something went wrong compiling the JLL that caused it to no pick up |
Indeed, the scheduled CI from this morning (https://github.com/oscar-system/GAP.jl/actions/runs/13105678001/job/36560073838) was completely green, with only the world-age warnings from Documenter. So in some sense, this change makes it worse than before. |
I can reproduce this locally so it is not something weird in the CI. But I also used a disassembler to look at the However comparing it with a locally built |
julia nightly now refers to 1.13-DEV, for which we don't have a libjulia yet (x-ref JuliaPackaging/Yggdrasil#10429). After #1141 is merged, we can at least see CI running on 1.12-DEV again. |
The 1.12 tests only show warnings about I am looking into the 1.13 failure, this probably has to do with Aqua.jl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now.
Two things to note:
- The name of the 1.11 CI job seems to have changed. @fingolfin could you please update the list of required CI jobs to reflect that?
- There are still some errors in
nightly
everytime we try to access singular (ref https://github.com/oscar-system/GAP.jl/actions/runs/13178758178/job/36784187046?pr=1139#step:11:314). This will probably fix itself oncelibsingular_julia_jll
gets rebuild with julia 1.13 support.
No description provided.