Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGES.md #1143

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Update CHANGES.md #1143

merged 2 commits into from
Feb 6, 2025

Conversation

fingolfin
Copy link
Member

There are a bunch of changes but most are not really user facing. Not even the --packagedirs one (except that perhaps PackageManager is slightly broken...)

[skip ci]

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.53%. Comparing base (0f83ffd) to head (55cecdd).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1143      +/-   ##
==========================================
- Coverage   82.74%   74.53%   -8.21%     
==========================================
  Files          50       55       +5     
  Lines        3824     4716     +892     
==========================================
+ Hits         3164     3515     +351     
- Misses        660     1201     +541     

see 9 files with indirect coverage changes

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once #1139 is merged

CHANGES.md Show resolved Hide resolved
@fingolfin fingolfin merged commit dbf891d into oscar-system:master Feb 6, 2025
17 of 20 checks passed
@fingolfin fingolfin deleted the mh/CHANGES branch February 6, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants