Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of doctest runs #1129

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

lgoettgens
Copy link
Member

Currently we run the doctests in CI in the following cases:

  1. In each CI / test run of the julia version-OS-matrix once via
    include("doctest.jl")
  2. In the CI / Documentation job twice. One time explicitly from the workflow yml configuration file, and another time by passing doctest = true to makedocs.

I don't really care about the makedocs case. But I really would like to remove the step from the documentation building workflow as a preliminary step towards working on #964.

@lgoettgens lgoettgens requested a review from fingolfin January 24, 2025 14:16
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.65%. Comparing base (be6e4e2) to head (e5ef53e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1129      +/-   ##
==========================================
+ Coverage   74.66%   81.65%   +6.98%     
==========================================
  Files          55       50       -5     
  Lines        4713     3821     -892     
==========================================
- Hits         3519     3120     -399     
+ Misses       1194      701     -493     

see 8 files with indirect coverage changes

@fingolfin fingolfin merged commit 1adfd06 into oscar-system:master Jan 28, 2025
166 checks passed
@lgoettgens lgoettgens deleted the lg/less-doctesting branch January 28, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants