Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out write_sysinfo_gap helper #1154

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Factor out write_sysinfo_gap helper #1154

merged 2 commits into from
Feb 10, 2025

Conversation

fingolfin
Copy link
Member

Slimming down regenerate_gaproot() further...

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.53%. Comparing base (50aca12) to head (44d2ce7).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
+ Coverage   74.52%   74.53%   +0.01%     
==========================================
  Files          55       55              
  Lines        4714     4716       +2     
==========================================
+ Hits         3513     3515       +2     
  Misses       1201     1201              
Files with missing lines Coverage Δ
src/setup.jl 78.57% <100.00%> (+0.38%) ⬆️

@fingolfin fingolfin requested a review from lgoettgens February 10, 2025 13:06
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment

src/setup.jl Outdated Show resolved Hide resolved
Co-authored-by: Lars Göttgens <[email protected]>
@fingolfin fingolfin enabled auto-merge (squash) February 10, 2025 14:10
@fingolfin fingolfin merged commit 4a7f55e into master Feb 10, 2025
170 checks passed
@fingolfin fingolfin deleted the mh/read-write-sysinfo branch February 10, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants