Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly qualify constructors that are extended #1157

Merged

Conversation

lgoettgens
Copy link
Member

to silence the warnings introduced in JuliaLang/julia#57311.

@lgoettgens lgoettgens requested a review from fingolfin February 10, 2025 13:53
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.52%. Comparing base (50aca12) to head (d077add).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1157   +/-   ##
=======================================
  Coverage   74.52%   74.52%           
=======================================
  Files          55       55           
  Lines        4714     4714           
=======================================
  Hits         3513     3513           
  Misses       1201     1201           
Files with missing lines Coverage Δ
src/constructors.jl 97.56% <100.00%> (ø)

@fingolfin fingolfin enabled auto-merge (squash) February 10, 2025 14:15
@fingolfin fingolfin merged commit 76f3b7e into oscar-system:master Feb 10, 2025
169 checks passed
@lgoettgens lgoettgens deleted the lg/explicitly-extend-constructors branch February 10, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants