Skip to content

Commit

Permalink
fix: vertices documentation and references
Browse files Browse the repository at this point in the history
  • Loading branch information
YueRen committed Aug 14, 2024
1 parent 112b83b commit 7b5e034
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/src/PolyhedralGeometry/polyhedral_complexes.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ n_vertices(PC::PolyhedralComplex)
polyhedra_of_dim
rays(PC::PolyhedralComplex{T}) where T<:scalar_types
rays_modulo_lineality(PC::PolyhedralComplex{T}) where T<:scalar_types
vertices(PC::PolyhedralComplex)
vertices(as::Type{PointVector{T}}, PC::PolyhedralComplex{T}) where {T<:scalar_types}
vertices_and_rays(PC::PolyhedralComplex{T}) where T<:scalar_types
```
4 changes: 2 additions & 2 deletions src/PolyhedralGeometry/PolyhedralComplex/properties.jl
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ julia> ambient_dim(PC)
ambient_dim(PC::PolyhedralComplex) = Polymake.fan.ambient_dim(pm_object(PC))::Int

@doc raw"""
vertices([as::Type{T} = PointVector,] PC::PolyhedralComplex)
vertices(as::Type{PointVector{T}}, PC::PolyhedralComplex{T}) where {T<:scalar_types}

This comment has been minimized.

Copy link
@lgoettgens

lgoettgens Aug 14, 2024

Member

This change shouldn't be necessary, see my comment in #4009

This comment has been minimized.

Copy link
@YueRen

YueRen Aug 14, 2024

Author Member

You're right, it is removed in the latest version of the pull request.

Return an iterator over the vertices of `PC` in the format defined by `as`. The
vertices are defined to be the zero-dimensional faces, so if `P` has lineality,
Expand Down Expand Up @@ -253,7 +253,7 @@ translation `p+L`, where `p` is only unique modulo `L`. The return type is a
dict, the key `:base_points` gives an iterator over such `p`, and the key
`:lineality_basis` lets one access a basis for the lineality space `L` of `PC`.
See also [`vertices`](@ref) and [`lineality_space`](@ref).
See also [`vertices(as::Type{PointVector{T}}, PC::PolyhedralComplex{T}) where {T<:scalar_types}`](@ref) and [`lineality_space`](@ref).
# Examples
```jldoctest
Expand Down

0 comments on commit 7b5e034

Please sign in to comment.