Tjurina Algebra/Number and finite determinancy for Hypersurfaces #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjurina algebra, tjurina number, determinancy bounds, contact equivalence for IHS
afkafkafk13
reviewed
Mar 10, 2024
afkafkafk13
reviewed
Mar 10, 2024
fingolfin
reviewed
Mar 10, 2024
|
(Just to be clear, overall this PR is fine, the things I pointed out are all minor details and should hopefully to be easy to resolve) |
Co-authored-by: Max Horn <[email protected]>
is_finitelydetermined -> is_finitely_determined w.r.t. -> with respect to vcat -> append! resp. push! and minor changes
|
@fingolfin Thank you for your suggestions. They have been quite helpful. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3495 +/- ##
==========================================
+ Coverage 82.18% 82.23% +0.05%
==========================================
Files 563 564 +1
Lines 75850 76057 +207
==========================================
+ Hits 62334 62548 +214
+ Misses 13516 13509 -7
|
tjurina number now returns infinity instead of -1 added more test using smaller k-th tjurina algebra for Mather-Yau in pos. char. to reduce computing effort
afkafkafk13
reviewed
Mar 19, 2024
afkafkafk13
approved these changes
Mar 19, 2024
|
Concerning the tests: The structure of including a file in experimental has changed. You need to add your file in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
-Tjurina algebra and number for Hypersurfaces
-upper determinancy bounds w.r.t. right resp. contact equivalence for IHS
-contact equivalence via Mather-Yau for IHS
(developed at the request of @afkafkafk13)