Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polyhedral/remove_zero_rows: use polymake epsilon for float comparison #3521

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

benlorenz
Copy link
Member

fixes #3520
cc: @YueRen

@benlorenz benlorenz requested a review from alexej-jordan March 16, 2024 10:38
@YueRen
Copy link
Member

YueRen commented Mar 16, 2024

Great, thank you!

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Merging #3521 (3a69626) into master (f7024a7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3521   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         566      566           
  Lines       76134    76136    +2     
=======================================
+ Hits        62515    62517    +2     
  Misses      13619    13619           
Files Coverage Δ
src/PolyhedralGeometry/helpers.jl 80.98% <100.00%> (+0.13%) ⬆️

@benlorenz benlorenz merged commit 4976a6f into master Mar 16, 2024
25 of 27 checks passed
@benlorenz benlorenz deleted the bl/pmeps branch March 16, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken polyhedron over Float64
3 participants