Handle empty charts for subschemes of ideal sheaves #3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (V, Vnew) in new_patches | ||
| (U, V) in keys(gluings(C)) || continue # No gluing before, no gluing after. | ||
| old_glue = C[U, V] | ||
| new_gluings[(Unew, Vnew)] = LazyGluing(Unew, Vnew, _compute_restriction, |
There was a problem hiding this comment.
it seems to me that the variable _compute_restriction is undefined?
There was a problem hiding this comment.
It is a function which is passed on as an argument.
Maybe this just reads a little odd?
There was a problem hiding this comment.
Yes, it is the function name to be used in the lazy gluing. A function of this name is available in LazyGluing.jl.
(Sorry this was typed at the same time as Hechti's answer, but took longer to upload (slow line).)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was pointed out by @afkafkafk13 in #3494, the constructor for subschemes from ideal sheaves had some deficiencies. This should be ruled out with this fix.