New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few fixes in `QuadFormAndIsom` #3539

Merged

simonbrandhorst merged 1 commit into oscar-system:master from StevellM:sm/fixes_qfai

Apr 3, 2024

Member

StevellM commented Mar 22, 2024

Fix subgroup enumeration for pairs of unimodular lattices (unimodular lattices are considered elementary for the prime number p = 1... forgot about this corner case).
Fix the early exit of the functions when classification == :first, :none.
Remove useless code block.


          fix non-classification outputs + fix for unimodular summands

8ab8eaf

simonbrandhorst approved these changes

View reviewed changes

simonbrandhorst merged commit 56b148e into oscar-system:master

27 checks passed

lgoettgens added the experimental label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels