Hide Oscar.jl banner, when used in other module #3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3541 +/- ##
==========================================
+ Coverage 81.68% 81.72% +0.04%
==========================================
Files 569 573 +4
Lines 77379 77503 +124
==========================================
+ Hits 63204 63343 +139
+ Misses 14175 14160 -15
|
lkastner
force-pushed
the
lk/banners
branch
2 times, most recently
from
b303ffd to
db8ff73
Compare
benlorenz
approved these changes
Apr 11, 2024
lgoettgens
approved these changes
Apr 11, 2024
|
Is this suitable for backporting? |
lgoettgens
added
the
backport 1.0.x
Probably yes, could be considered as a bug fix...? And we do have the corresponding AbstractAlgebra in the deps anyway. |
benlorenz
pushed a commit
that referenced
this pull request
Apr 12, 2024
Hide Oscar banner, when used in other module (cherry picked from commit 6894701)
Merged
benlorenz
removed
the
backport 1.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Nemocas/AbstractAlgebra.jl#1643