[FTheoryTools] Introduce optional argument generic for literature model constructor #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HereAround
commented
Apr 10, 2024
Comment on lines
-273
to
+286
| # Lead to error when computing singular loci - currently only monomials allowed... | ||
| #explicit_model_sections[key] = basis_of_global_sections(toric_line_bundle(value))[end] | ||
| if generic | ||
| explicit_model_sections[key] = generic_section(toric_line_bundle(value)) | ||
| else | ||
| explicit_model_sections[key] = basis_of_global_sections(toric_line_bundle(value))[end] | ||
| end |
There was a problem hiding this comment.
This is the key change/proposal to make the book example function again. The remainder is cosmetics, including a doc test that will fail if there is a new breaking change to said book example.
apturner
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Thank you @HereAround, I think this makes sense and is the simplest fix for the problem we're in.
|
@lkastner This is the fix that is needed to make the book work again. I believe this also needs a backport to 1.0.x. |
Merged
benlorenz
removed
the
backport 1.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apturner A proposal to fix the book example by introducing an optional argument to the literature model constructor.