GModule: replace _hom
#3603
Merged
GModule: replace _hom
#3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the images of generators directly, instead of first creating pseudo-inverses and compositions of maps. (Eventually, restricting the group action to a submodule should become a function of its own.)
|
On Fri, Apr 12, 2024 at 05:22:21AM -0700, Thomas Breuer wrote:
Create the images of generators directly, instead of first creating pseudo-inverses and compositions of maps.
(Eventually, restricting the group action to a submodule should become a function of its own.)
I think sub(GModule, module or similar) already exists...
… (also fixed a call of `maximal_submodule_bases`)
You can view, comment on, or merge this pull request online at:
#3603
-- Commit Summary --
* `GModule`: replace `_hom`
* fix a call of `maximal_submodule_bases`
-- File Changes --
M experimental/GModule/GModule.jl (15)
M experimental/GModule/test/runtests.jl (4)
-- Patch Links --
https://github.com/oscar-system/Oscar.jl/pull/3603.patch
https://github.com/oscar-system/Oscar.jl/pull/3603.diff
--
Reply to this email directly or view it on GitHub:
#3603
You are receiving this because your review was requested.
Message ID: ***@***.***>
|
|
O.k., |
|
On Fri, Apr 12, 2024 at 05:47:06AM -0700, Thomas Breuer wrote:
O.k., `sub(M::GModule, phi::Map)` shall take an embedding with codomain `M` and shall return `S, emb` such that `S` is a `GModule` for the same group as `M` but with module `S`.
(I have not found this, will add it.)
I thought you even fixed a bug in it...
… --
Reply to this email directly or view it on GitHub:
#3603 (comment)
You are receiving this because your review was requested.
Message ID: ***@***.***>
|
|
There is |
fingolfin
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the images of generators directly, instead of first creating pseudo-inverses and compositions of maps.
(Eventually, restricting the group action to a submodule should become a function of its own.)
(also fixed a call of
maximal_submodule_bases)