Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP on elliptic fibrations again #3609

Merged
merged 74 commits into from
Apr 17, 2024
Merged

WIP on elliptic fibrations again #3609

merged 74 commits into from
Apr 17, 2024

Conversation

HechtiDerLachs
Copy link
Collaborator

@HechtiDerLachs
Squashed changes.
8d8241d
@HechtiDerLachs
Remove methods for preimages.
cb5007f
@HechtiDerLachs
Add some methods for dim and remove debug messages.
23430fd
@HechtiDerLachs
Revert temporary workarounds for MPolyQuo.jl.
17872ac
@HechtiDerLachs
Revert hotfixes for modules over quotient rings.
87e92a6
@HechtiDerLachs
Remove duplicate line.
ed08eae
@HechtiDerLachs
Remove deprecated code.
6693690
@HechtiDerLachs
Revert "Remove methods for preimages."
d12a2f0 
This reverts commit dbeb35d.
@HechtiDerLachs
Revert changes in derived pushforwards.
22789f9
@HechtiDerLachs
Clean up docstrings for preimages of ideals.
791dab0
@HechtiDerLachs
Fix docstrings.
a18ec5b
@HechtiDerLachs
Fix setting of attributes.
5be1f5b
@HechtiDerLachs
Remove changes by only trailing whitespaces.
69d0178
@HechtiDerLachs
Remove typo.
b09a44d
@HechtiDerLachs
Revert "Remove typo."
066c03e 
This reverts commit 50978be.
@HechtiDerLachs
Remove typo.
f17089a
@HechtiDerLachs
Fix dummy method for docstring.
e1b2099
@HechtiDerLachs
Reroute computation of dimensions for localized ideals at rational po…
b229140 
…ints.
@HechtiDerLachs
Add tests.
2883822
@HechtiDerLachs
Fix test file for covered schemes.
a62b835
@HechtiDerLachs
Fix docs.
1e67410
@HechtiDerLachs
Fix doctests.
c5f1a2a
@HechtiDerLachs
Fix method ambiguity.
6ca2b65
@HechtiDerLachs
Move docstring and export abstract type.
303266a
@HechtiDerLachs
Avoid factorization in simplification of multiplicative sets.
a7f7097
@HechtiDerLachs
Avoid slow multiplication in creation of pos.
2ffe08e
@HechtiDerLachs
Remove method ambiguity.
b2b5ba6
@HechtiDerLachs
Fix tests.
c39db94
@HechtiDerLachs
Repair creation of prime ideals from charts.
6b77ee3
@HechtiDerLachs
Remove weird preimage tests.
5dd3da7
simonbrandhorst
simonbrandhorst requested changes Apr 16, 2024
View reviewed changes
@HechtiDerLachs
Copy link
Collaborator Author

The PR seems to have become a bit bigger, because I moved the type declarations out of src/Rings/mpoly-localizations.jl. But that is just code migration and nothing has changed about its internals.

Other than that, I think I addressed all relevant issues raised by the review.

@HechtiDerLachs HechtiDerLachs marked this pull request as ready for review April 17, 2024 13:34
@simonbrandhorst
Copy link
Collaborator

Awsome, thanks a long for this huge piece of work! I wonder if we can soon enable some of the tests that were previously far too slow to ever run.

@simonbrandhorst simonbrandhorst enabled auto-merge (squash) April 17, 2024 14:09
@simonbrandhorst simonbrandhorst merged commit 183cbe6 into oscar-system:master Apr 17, 2024
25 of 26 checks passed
@HechtiDerLachs HechtiDerLachs deleted the oguiso_rebase6 branch April 17, 2024 15:04
@lgoettgens lgoettgens mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbrandhorst simonbrandhorst simonbrandhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HechtiDerLachs @simonbrandhorst