Adding Graphical Models in Experimental #3621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marina's Code and my Code combined.
…e we agreed upon.
… PhylogeneticModels.jl
… statements in GraphicalModels.jl
lgoettgens
reviewed
May 2, 2024
Comment on lines
124
to
127
| julia> pm = jukes_cantor_model(graph_from_edges(Directed,[[4,1],[4,2],[4,3]])); | ||
| julia> sum_equivalent_classes(pm) | ||
|
|
||
| Dict{Vector{Tuple{Int64, Int64, Int64}}, QQMPolyRingElem} with 5 entries: |
There was a problem hiding this comment.
Suggested change
| julia> pm = jukes_cantor_model(graph_from_edges(Directed,[[4,1],[4,2],[4,3]])); | |
| julia> sum_equivalent_classes(pm) | |
| Dict{Vector{Tuple{Int64, Int64, Int64}}, QQMPolyRingElem} with 5 entries: | |
| julia> pm = jukes_cantor_model(graph_from_edges(Directed,[[4,1],[4,2],[4,3]])); | |
| julia> sum_equivalent_classes(pm) | |
| Dict{Vector{Tuple{Int64, Int64, Int64}}, QQMPolyRingElem} with 5 entries: |
wrong whitespace will make the doctest fail (similar at many other places)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3621 +/- ##
==========================================
- Coverage 82.18% 81.26% -0.92%
==========================================
Files 563 584 +21
Lines 75862 79461 +3599
==========================================
+ Hits 62345 64577 +2232
- Misses 13517 14884 +1367
|
|
Merged into new pull request Algebraic Statistics #3812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial draft pull request for working with algebraic phylogenetics and graphical models