Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] More models from "F-theory on all toric hypersurfaces" #3642

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

HereAround
Copy link
Member

@HereAround HereAround commented Apr 23, 2024

  • Extend index creation,
  • Enable more models,
  • Extend tests accordingly.

cc @apturner @emikelsons

(Cf. #3635)

@HereAround HereAround requested a review from apturner April 23, 2024 22:13
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #3642 (435397e) into master (f308003) will decrease coverage by 0.01%.
The diff coverage is 21.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3642      +/-   ##
==========================================
- Coverage   82.78%   82.78%   -0.01%     
==========================================
  Files         577      577              
  Lines       77755    77760       +5     
==========================================
  Hits        64370    64370              
- Misses      13385    13390       +5     
Files Coverage Δ
.../FTheoryTools/src/LiteratureModels/constructors.jl 92.30% <60.00%> (-0.40%) ⬇️
.../FTheoryTools/src/LiteratureModels/create_index.jl 0.00% <0.00%> (ø)

@HereAround HereAround merged commit bbb45d8 into oscar-system:master Apr 26, 2024
29 checks passed
@HereAround HereAround deleted the MoreFixes branch April 26, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants