Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #3648

Merged
merged 4 commits into from
Apr 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/src/General/faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ our context due to two independent problems:
At least two reasons:
- The type depends on data that is not a bit-type.
- Even if it could, it is not desirable. Typical example: computations in
``Z/nZ``, so modular arithmetic. If ``n`` is small, then it is tempting to
``\mathbb Z/n\mathbb Z``, so modular arithmetic. If ``n`` is small, then it is tempting to
define a type `T` depending on ``n``. We actually did this, and tried to
use this. It did not work well, for various reasons. E.g.:

Expand All @@ -102,7 +102,7 @@ In OSCAR, the role of the type is split between the actual Julia type and the

Almost all element-like objects in OSCAR have a parent, i.e., they belong to
some larger structure. For example algebraic numbers belong to a number field,
modular integers belong to a ring ``Z/nZ``, permutations are elements of
modular integers belong to a ring ``\mathbb Z/n\mathbb Z``, permutations are elements of
permutation groups and so on. The data common to all such elements is
out-sourced to the parent. For a number field for example, the parent contains
the polynomial used to define the field (plus other information).
Expand Down Expand Up @@ -135,7 +135,7 @@ can be done via `GAP.Packages.install`, where the first argument is this URL.

Many of the algorithms implemented in OSCAR have a very high complexity. Even
if not calling one of these algorithms directly, you may be using it in the
background. Please read our page on [Complex Algorithms in OSCAR].
background. Please read our page on [Complex Algorithms in OSCAR](@ref).

---

Expand Down
4 changes: 2 additions & 2 deletions experimental/LieAlgebras/src/LieAlgebraModule.jl
Original file line number Diff line number Diff line change
Expand Up @@ -873,8 +873,8 @@ end

# TODO: add caching
@doc raw"""
tensor_product(Vs::LieAlgebraModule{C}...) -> LieAlgebraModule{C}
⊗(Vs::LieAlgebraModule{C}...) -> LieAlgebraModule{C}
tensor_product(Vs::LieAlgebraModule{C}...) -> LieAlgebraModule{C}
⊗(Vs::LieAlgebraModule{C}...) -> LieAlgebraModule{C}
Given modules $V_1,\dots,V_n$ over the same Lie algebra $L$,
construct their tensor product $V_1 \otimes \cdots \otimes \V_n$.
Expand Down
2 changes: 1 addition & 1 deletion src/InvariantTheory/types.jl
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ end

struct MSetPartitions{T}
M::MSet{T}
num_to_key::Vector{Int}
num_to_key::Vector{T}
key_to_num::Dict{T,Int}

function MSetPartitions(M::MSet{T}) where {T}
Expand Down
1 change: 0 additions & 1 deletion src/Rings/MPolyMap/AffineAlgebras.jl
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ function has_preimage_with_preimage(F::AffAlgHom, f::Union{MPolyRingElem, MPolyQ

T, inc, pr, J = _groebner_data(F)
o = induce(gens(T)[1:n], default_ordering(S))*induce(gens(T)[n + 1:end], default_ordering(R))
gb = groebner_basis(J, ordering = o)
nf = normal_form(inc(lift(f)), J, ordering = o)
if isone(cmp(o, gen(T, n), leading_monomial(nf, ordering = o)))
return true, pr(nf)
Expand Down
Loading