Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Experimental: Partitioned Permutations #3724

Merged

Conversation

BjSchaefer
Copy link
Contributor

This is to add a documentation for the module Partitioned Permutations in Experimental. Further, we update some information in the Readme.

The module Partitioned Permutations has been introduced in the previous pull request #3439.

@lgoettgens lgoettgens added the experimental Only changes experimental parts of the code label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (1c7c040) to head (ec6a710).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3724   +/-   ##
=======================================
  Coverage   81.34%   81.35%           
=======================================
  Files         577      577           
  Lines       78638    78646    +8     
=======================================
+ Hits        63971    63982   +11     
+ Misses      14667    14664    -3     
Files Coverage Δ
...titionedPermutations/src/PartitionedPermutation.jl 79.31% <ø> (ø)

... and 71 files with indirect coverage changes

Copy link
Member

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!
I don't know about the math of course...

@joschmitt
Copy link
Member

If nobody else has objections, then please merge.

@BjSchaefer
Copy link
Contributor Author

So, who could please merge this pull request? @lgoettgens, you merged #3439. Would you do the same now?

@lgoettgens lgoettgens merged commit f9e5c0f into oscar-system:master May 16, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants