Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct sums of Lie algebras #3896

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Jun 28, 2024

This currently contains #3894 and needs to get rebased once that is merged. So please skip the first commit when reviewing this.

This is only a first sketch, there will possibly be changes (and documentation) at a later point.
I am aware that this does not (yet) is completely as #3059 wants it to be, put this is in the big part due to some generic functionality not being there to get used and me thus needing to include some of the generic functions myself (but restricted to the types here). All of this can be significantly simplified once there has been some more progress towards #3059.

@lgoettgens lgoettgens added topic: LieTheory experimental Only changes experimental parts of the code labels Jun 28, 2024
@lgoettgens lgoettgens force-pushed the lg/DirectSumLieAlgebra branch from 5b6ffb8 to 9f45893 Compare July 2, 2024 11:44
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 75.60976% with 20 lines in your changes missing coverage. Please review.

Project coverage is 83.87%. Comparing base (f2697ea) to head (9f45893).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3896      +/-   ##
==========================================
- Coverage   83.88%   83.87%   -0.02%     
==========================================
  Files         588      590       +2     
  Lines       80922    81000      +78     
==========================================
+ Hits        67885    67942      +57     
- Misses      13037    13058      +21     
Files Coverage Δ
experimental/LieAlgebras/src/LieAlgebraHom.jl 85.10% <100.00%> (+0.16%) ⬆️
experimental/LieAlgebras/src/LieAlgebras.jl 100.00% <ø> (ø)
...ental/LieAlgebras/test/DirectSumLieAlgebra-test.jl 100.00% <100.00%> (ø)
...xperimental/LieAlgebras/src/DirectSumLieAlgebra.jl 72.60% <72.60%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@HereAround HereAround left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lgoettgens looks great to me.

@HereAround HereAround merged commit 86867c7 into oscar-system:master Jul 3, 2024
28 of 29 checks passed
@lgoettgens lgoettgens deleted the lg/DirectSumLieAlgebra branch July 3, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code topic: LieTheory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants