hasse_deriv finished for MPolyLocRing and MPolyQuoRing

src/AlgebraicGeometry/HasseSchmidt/HasseSchmidtDerivative.jl

@@ -42,8 +42,8 @@ function pseudo_diff(f, j, A, q, I::Ideal, systemOfParameters::Vector{Int})
   end
 
   # See formular in remark 4.2
-  for k in 1:n_cols(A)
-    for l in 1:n_rows(A)
+  for k in 1:ncols(A)
+    for l in 1:nrows(A)
       SubPoly = derivative(gens(I)[l], systemOfParameters[j]) * A[l,k] * derivative(f, OtherVars[k])
       RetPoly = RetPoly - SubPoly
     end
@@ -66,12 +66,6 @@ function integer_generator(I)
   return (J)
 end
 
-
-
-# function hasse_deriv(f) # Hs-derivative for one polynomial
-
-# end
-
 ####################################################################################
 #####################   HASSE-SCHMIDT DERIVATIVE  (IZ == <0>)  ##################### 
 # Name:		hasse_deriv
@@ -97,6 +91,7 @@ function hasse_deriv(IX::MPolyQuoIdeal)
 end
 
 function hasse_deriv(IX::Oscar.MPolyLocalizedIdeal)
+  # Rloc.(I.gens)
   Rloc = base_ring(IX)
   R = base_ring(Rloc) # could cause problems if this isn't a MPolyRing
   # projecting the generators of IX onto the base_ring of Rloc by taking the numerators
@@ -159,10 +154,28 @@ end
 # OUTPUT:	List of ideals generated by hasse derivatives until but without <1>
 
 function hasse_deriv(IZ::MPolyQuoIdeal, IX::MPolyQuoIdeal, systemOfParameters::Vector{Int}, M)
+  RQ = base_ring(IX)
+  R = base_ring(RQ) # could cause problems if this isn't a MPolyRing
+  # embedding the generators of IX and IZ into the base_ring of RQ
+  IX_R = ideal(R, [R(gen) for gen in gens(IX)])
+  IZ_R = ideal(R, [R(gen) for gen in gens(IZ)])
 
+  # systemOfParameters needs no change because it beeing Vector{Int} ist just fine
+  nRows = n_rows(M)
+  nCols = n_columns(M)
+  M_R = matrix(R, nRows, nCols, [R(M[i,j]) for i in 1:nRows for j in 1:nCols])
+
+  list_IX_derivs = hasse_deriv(IZ_R, IX_R, systemOfParameters, M_R) # calling hasse_deriv for MPolyIdeals
+
+  # projecting the hasse derivs onto original localized ring
+  return_list = empty([]) 
+  for i in 1:length(list_IX_derivs)
+    push!(return_list, ideal(Rloc, [Rloc(gen) for gen in gens(list_IX_derivs[i])]))
+  end
+  return return_list
 end
 
-function hasse_deriv(IZ::Oscar.MPolyLocalizedIdeal, IX::Oscar.MPolyLocalizedIdeal, systemOfParameters, M)
+function hasse_deriv(IZ::Oscar.MPolyLocalizedIdeal, IX::Oscar.MPolyLocalizedIdeal, systemOfParameters::Vector{Int}, M)
   Rloc = base_ring(IX)
   R = base_ring(Rloc) # could cause problems if this isn't a MPolyRing
   # projecting the generators of IX and IZ onto the base_ring of Rloc by taking the numerators
@@ -176,7 +189,7 @@ function hasse_deriv(IZ::Oscar.MPolyLocalizedIdeal, IX::Oscar.MPolyLocalizedIdea
   nCols = n_columns(M)
   M_R = matrix(R, nRows, nCols, [numerator(M[i,j]) for i in 1:nRows for j in 1:nCols])
 
-  list_IX_derivs = hasse_deriv(IZ_R, IX_R) # calling hasse_deriv for MPolyIdeals
+  list_IX_derivs = hasse_deriv(IZ_R, IX_R, systemOfParameters, M_R) # calling hasse_deriv for MPolyIdeals
 
   # embedding the hasse derivs into original localized ring
   return_list = empty([]) 

src/AlgebraicGeometry/HasseSchmidt/examplesHasseSchmidt.jl

@@ -81,8 +81,28 @@ IX = IZ + ideal(R, [x[4]^3 + x[6]^4]) # working
 hasse_deriv(IZ, IX, y, M)
 
 ### FAKTORRING / QUOTIENTENRING
+R, (x, y, z) = polynomial_ring(QQ, ["x", "y", "z"])
+I = ideal(R, [x - 1])
+RQ, _ = quo(R, I)
+IZ = ideal(RQ, [y - 1])
+IX = IZ + ideal(RQ, [-y^3 + x^2])
+systemOfParameters = [3]
+M = matrix(RQ, 1, 1, [z])
+
+hasse_deriv(IZ, IX, systemOfParameters, M) # debuggen (endlosschleife), ? x-1 und y-1 sorgen für IX = 0 in RQ ?
+# sollte ich auf IX = 0 prüfen? wo prüfe ich bisher auf IX = 0 ? kommt hasse_deriv mit IX = 0 nicht klar?
 
 ### LOKALISIERTER RING
+R, (x, y, z) = polynomial_ring(QQ, ["x", "y", "z"])
+P = ideal(R, [x])
+U = complement_of_prime_ideal(P)
+Rloc, iota = localization(R, U)
+IZ = ideal(Rloc, [y - 1])
+IX = IZ + ideal(Rloc, [-y^3 + x^2])
+systemOfParameters = [1, 3]
+M = matrix(Rloc, 1, 1, [z])
+
+hasse_deriv(IZ, IX, systemOfParameters, M)
 
 # Oscar.MPolyLocalizedIdeal
 R, (x, y, z) = polynomial_ring(QQ, ["x", "y", "z"])
@@ -92,6 +112,7 @@ Rloc, iota = localization(R, U)
 IZ = ideal(Rloc, [zero(Rloc)])
 IX = ideal(Rloc, [-y^3 + x^2])
 
+
 # MPolyQuoIdeal
 # T, t = polynomial_ring(QQ, "t")
 # K, a =  number_field(2*t^2-1, "a")