[FTheoryTools]Small QOL changes 2 #3941

emikelsons · 2024-07-16T09:25:32Z

Updated the FTheoryTools introduction page
Improved parsing of parametric models(now the language in the model_description isn't as restricted, but everything inside any brackets will still be evaluated)
weierstrass_model(h::HypersurfaceModel) now also constructs the appropriate model, if it has been specified in the database
Renamed related_models to birational_models and associated_models now only refer to models sharing the same paper
Added a function model_index that returns the database index of a literature model for future use

Expanded display_all_literature_models() so that now it's possible to filter for models with desired properties(gauge algebra etc.). Made new file model_indices.json that keeps track of a model's index. Running _create_literature_model_index() updates this file

Made some additional changes that should round out the previous PR

Bug due to recent renaming of things

At some point I accidentally must have undone my progress, which caused errors

codecov · 2024-07-16T15:09:56Z

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.01%. Comparing base (e3f1503) to head (f79f539).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3941   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files         592      592           
  Lines       81674    81694   +20     
=======================================
+ Hits        68617    68637   +20     
  Misses      13057    13057

Files	Coverage Δ
...heoryTools/src/AbstractFTheoryModels/attributes.jl	`98.58% <100.00%> (+0.02%)`	⬆️
...heoryTools/src/AbstractFTheoryModels/properties.jl	`100.00% <100.00%> (ø)`
.../FTheoryTools/src/HypersurfaceModels/attributes.jl	`93.10% <100.00%> (+3.10%)`	⬆️
.../FTheoryTools/src/LiteratureModels/constructors.jl	`95.63% <100.00%> (+0.10%)`	⬆️
.../FTheoryTools/src/AbstractFTheoryModels/methods.jl	`74.53% <0.00%> (ø)`

HereAround · 2024-07-16T18:01:08Z

experimental/FTheoryTools/docs/src/introduction.md

+- Quadrillion F-Theory Compactifications with the Exact Chiral Spectrum of the Standard Model [CHLLT19](@cite).
+
+Consequently, we are already covering infinite families of models (e.g., with $SU(k)$ gauge group, where $k \geq 1$).
+Still, the total number of papers in our database is at this point limited to about $45$. This is to be extended a lot.


I think this number is not correct (although I did not check it). But I thought we have about 45 different models (including such models that give us an infinite family, say SU(n)), but that the number of papers from where those models originate is more like 10.

You're right I misread this originally

experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl

HereAround · 2024-07-16T18:05:23Z

experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl

+
+
+@doc raw"""
+    model_index(m::AbstractFTheoryModel)


I like this! Thank you.

HereAround · 2024-07-16T18:14:58Z

I just checked the introduction page https://docs.oscar-system.org/dev/Experimental/FTheoryTools/introduction/. A couple more suggestions:

Mikelis, please add yourself to the list of people to reach out to. (Currently only Andrew and I are listed.)
Maybe we can also remove the line break before "Alternatively, you can raise an issue on github."
Could we please extend the funding information (very bottom of the page): "Martin Bies and Mikelis Mikelsons appreciate support by the TU-Nachwuchsring".

Related question for @apturner: Is your funding information as stated on the introduction page still up-to-date?

HereAround · 2024-07-16T18:16:37Z

I left a few nitpicks above. Generally speaking though, I really like those changes. Thank you for working on this @emikelsons !

apturner · 2024-07-17T16:40:19Z

Related question for @apturner: Is your funding information as stated on the introduction page still up-to-date?

This is still accurate until the end of August, at which point it will change. For now, we can leave it as it is.

Expanded contact list and funding information

HereAround · 2024-07-18T08:43:01Z

experimental/FTheoryTools/docs/src/introduction.md

 * [Martin Bies](https://martinbies.github.io/),
-* [Andrew Turner](https://apturner.net/).
+* [Andrew Turner](https://apturner.net/),
+* [Mikelis Emils Mikelsons](https://github.com/emikelsons).


I would suggest alphabetic order by last name. Unless I am mistaken, this is the accepted standard OSCAR-wide.

So Bies, Mikelsons, Turner.

HereAround · 2024-07-18T08:43:53Z

experimental/FTheoryTools/docs/src/introduction.md

 Alternatively, you can [raise an issue on github](https://www.oscar-system.org/community/#how-to-report-issues).


 ## Acknowledgements

-We appreciate insightful discussions with [Mirjam Cvetič](https://live-sas-physics.pantheon.sas.upenn.edu/people/standing-faculty/mirjam-cvetic). The work of Andrew Turner is supported by DOE (HEP) Award DE-SC001352.
+We appreciate insightful discussions with [Mirjam Cvetič](https://live-sas-physics.pantheon.sas.upenn.edu/people/standing-faculty/mirjam-cvetic). Martin Bies and Mikelis Mikelsons appreciate support by the TU-Nachwuchsring. The work of Andrew Turner is supported by DOE (HEP) Award DE-SC001352.


Very good. Thank you!

HereAround

Thank you for working on this @emikelsons . Looks good to me!

emikelsons added 4 commits July 3, 2024 18:19

Small QOL changes

6f8fd46

Expanded display_all_literature_models() so that now it's possible to filter for models with desired properties(gauge algebra etc.). Made new file model_indices.json that keeps track of a model's index. Running _create_literature_model_index() updates this file

Merge remote-tracking branch 'upstream/master'

3bdceaf

Merge remote-tracking branch 'upstream/master'

1b4cdd9

Small QOL changes 2

7867337

Made some additional changes that should round out the previous PR

emikelsons added the topic: FTheoryTools label Jul 16, 2024

emikelsons requested review from HereAround and apturner July 16, 2024 09:27

emikelsons added 3 commits July 16, 2024 13:43

Update literature_models.jl

cbf7677

Bug due to recent renaming of things

Fixed more typos

5e81580

Fixed more bugs

3d8ab5f

At some point I accidentally must have undone my progress, which caused errors

HereAround reviewed Jul 16, 2024

View reviewed changes

experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl Outdated Show resolved Hide resolved

HereAround reviewed Jul 16, 2024

View reviewed changes

experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl Outdated Show resolved Hide resolved

HereAround reviewed Jul 16, 2024

View reviewed changes

emikelsons added 3 commits July 16, 2024 20:09

Update attributes.jl

e11c55b

Update attributes.jl

db78b9d

Update introduction.md

107025e

Update introduction.md

addbe0c

Expanded contact list and funding information

HereAround reviewed Jul 18, 2024

View reviewed changes

Update introduction.md

3a82435

HereAround approved these changes Jul 18, 2024

View reviewed changes

HereAround enabled auto-merge (squash) July 18, 2024 09:21

Merge remote-tracking branch 'upstream/master' into pr/3941

f79f539

HereAround merged commit f600a05 into oscar-system:master Jul 18, 2024
27 of 29 checks passed

emikelsons deleted the Small_QOL_changes_2 branch July 18, 2024 14:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FTheoryTools]Small QOL changes 2 #3941

[FTheoryTools]Small QOL changes 2 #3941

emikelsons commented Jul 16, 2024

codecov bot commented Jul 16, 2024 •

edited

Loading

HereAround Jul 16, 2024

emikelsons Jul 16, 2024

HereAround Jul 16, 2024

HereAround commented Jul 16, 2024 •

edited

Loading

HereAround commented Jul 16, 2024

apturner commented Jul 17, 2024

HereAround Jul 18, 2024

HereAround Jul 18, 2024

HereAround Jul 18, 2024

HereAround left a comment

[FTheoryTools]Small QOL changes 2 #3941

[FTheoryTools]Small QOL changes 2 #3941

Conversation

emikelsons commented Jul 16, 2024

codecov bot commented Jul 16, 2024 • edited Loading

Codecov Report

HereAround Jul 16, 2024

Choose a reason for hiding this comment

emikelsons Jul 16, 2024

Choose a reason for hiding this comment

HereAround Jul 16, 2024

Choose a reason for hiding this comment

HereAround commented Jul 16, 2024 • edited Loading

HereAround commented Jul 16, 2024

apturner commented Jul 17, 2024

HereAround Jul 18, 2024

Choose a reason for hiding this comment

HereAround Jul 18, 2024

Choose a reason for hiding this comment

HereAround Jul 18, 2024

Choose a reason for hiding this comment

HereAround left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 16, 2024 •

edited

Loading

HereAround commented Jul 16, 2024 •

edited

Loading