-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tropical determinant via Hungarian method #3943
Conversation
…ntation via Hungarian method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A very welcome change!
@danteluber please have a look |
Co-authored-by: YueRen <[email protected]>
code overhauled, will start new review once tests are through
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3943 +/- ##
==========================================
+ Coverage 84.00% 84.01% +0.01%
==========================================
Files 592 592
Lines 81624 81672 +48
==========================================
+ Hits 68566 68616 +50
+ Misses 13058 13056 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great. Thanks for this very useful feature!
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
The previous implementation (via Leibniz' rule) was not useful. It is now replaced via polymake's implementation of the Hungarian method.
To see the difference, here are two computations with v.1.1.1: