Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization Refactor #4162

Draft
wants to merge 48 commits into
base: master
Choose a base branch
from
Draft

Serialization Refactor #4162

Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
45d3516
some progress on simplifying ref handling in IPC Serialization
antonydellavecchia Sep 16, 2024
3e62a1b
some progress
antonydellavecchia Sep 16, 2024
8d76aab
moving things around
antonydellavecchia Sep 17, 2024
94587e3
type params function
antonydellavecchia Sep 17, 2024
e4c5bae
some progress on refactoring
antonydellavecchia Sep 18, 2024
1dfd391
some progress
antonydellavecchia Sep 19, 2024
c1cbd72
more progress
antonydellavecchia Sep 20, 2024
12eb6ef
almost completed uni variate polynomials
antonydellavecchia Sep 28, 2024
84c46e6
uni vairate polynomials serialization passing
antonydellavecchia Sep 28, 2024
e35b665
MPolyRing tests passing
antonydellavecchia Sep 29, 2024
4537cf0
moving things around
antonydellavecchia Sep 29, 2024
eb3c734
grading needs containers
antonydellavecchia Sep 30, 2024
a94c566
not sure where i left this
antonydellavecchia Oct 22, 2024
72a96cf
new load_type_params
antonydellavecchia Nov 5, 2024
5e06a82
bug with julia 1.11.1
antonydellavecchia Nov 6, 2024
4cbaee4
vectors + polynomials working
antonydellavecchia Nov 7, 2024
7255064
some progress on tuples
antonydellavecchia Nov 7, 2024
b41dee5
reworking save_type_params
antonydellavecchia Nov 11, 2024
d758fad
tidying
antonydellavecchia Nov 13, 2024
f61ecd1
dicts working
antonydellavecchia Nov 14, 2024
66a5f2e
containers completed, need some upgrades though
antonydellavecchia Nov 19, 2024
32bb5ee
tidying
antonydellavecchia Nov 21, 2024
47e3f3f
broke everything
antonydellavecchia Nov 21, 2024
d971bb5
fixed containers and polynomials
antonydellavecchia Dec 3, 2024
beea514
some issues with field embeddings
antonydellavecchia Dec 3, 2024
b6f35d3
fields tests working now
antonydellavecchia Dec 13, 2024
4b37896
algebras working
antonydellavecchia Jan 14, 2025
0b0d1de
started on groups
antonydellavecchia Jan 14, 2025
62b1bbc
Merge branch 'master' into adv/ipc-serialize
antonydellavecchia Jan 15, 2025
0324e87
fix, inconsistencies from merge
antonydellavecchia Jan 15, 2025
98fc56d
crawling through groups
antonydellavecchia Jan 15, 2025
49b0768
matrices working
antonydellavecchia Jan 16, 2025
a26a575
MPolyMap Working
antonydellavecchia Jan 16, 2025
f539b16
some progress on polyhedral objects
antonydellavecchia Jan 16, 2025
5404f73
adjust GAP serialization to the refactoring
ThomasBreuer Jan 18, 2025
0bb0cc7
GAP object serialization working
antonydellavecchia Jan 20, 2025
336c350
groups working
antonydellavecchia Jan 20, 2025
d322733
removed false kwarg in docs
antonydellavecchia Jan 20, 2025
af036e9
Lie Theory serialization working
antonydellavecchia Jan 20, 2025
215e946
stuck on regression in polyhedral
antonydellavecchia Jan 20, 2025
4ded0c1
simplify type_params
antonydellavecchia Jan 27, 2025
0efc726
fields working
antonydellavecchia Jan 27, 2025
a69c0d4
back to polyhedral
antonydellavecchia Jan 27, 2025
faa656b
graded ring working
antonydellavecchia Jan 28, 2025
81cb2e8
sets not passing yet
antonydellavecchia Jan 28, 2025
4ee31af
started to change docs a bit
antonydellavecchia Jan 28, 2025
0fd56a2
fix some set tests
antonydellavecchia Jan 28, 2025
54ce61d
progress on polyhedral objects
antonydellavecchia Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Combinatorics/SimplicialComplexes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ function automorphism_group(K::SimplicialComplex; action=:on_vertices)
end

@doc raw"""
on_simplicial_complex(K::SimplicialComplex, g::PermGroupElem)
on_simplicial_complex(K::SimplicialComplex, g::PermGroupElem; action=:on_vertices)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this maybe a conflict resolution artifact? it does not match the signature of the function this docstring is attached to


Given a simplicial complex `K` return the simplicial complex corresponding
to a permutation on it's vertices given by `g`.
Expand Down
2 changes: 1 addition & 1 deletion src/Serialization/Algebras.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ end
# Free associative algebra element serialization
@register_serialization_type FreeAssociativeAlgebraElem uses_params

# see save_type_params in Rings
# see type_params in Rings

function save_object(s::SerializerState, f::FreeAssociativeAlgebraElem)
save_data_array(s) do
Expand Down
Loading