-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backfill 1.2.2 to changelog #4472
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # Changelog | ||
|
|
||
| All notable changes to this project will be documented in this file. | ||
|
|
||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project | ||
| tries to adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
|
|
||
| ## [Unreleased] | ||
|
|
||
| ### Added | ||
|
|
||
| - Started keeping a changelog. Added a changelog file, and added a changelog nagger to CI. | ||
|
|
||
| ### Changed | ||
|
|
||
| ### Deprecated | ||
|
|
||
| ### Removed | ||
|
|
||
| ### Fixed | ||
|
|
||
| ### Security | ||
|
|
||
| ## [1.2.2] - 2024-12-13 | ||
|
|
||
| ### Fixed | ||
|
|
||
| - Fixed a problem with `galois_group` [PR #4396](https://github.com/oscar-system/Oscar.jl/pull/4396) | ||
|
|
||
| - Fixed zero-dimensional cone in `cones` in PolyhedralGeometry. [PR | ||
| #4336](https://github.com/oscar-system/Oscar.jl/pull/4336) | ||
|
|
||
| - Fixed up generic characteristic method for localized rings. [issue | ||
| #4324](https://github.com/oscar-system/Oscar.jl/issues/4324) [PR | ||
| #4346](https://github.com/oscar-system/Oscar.jl/pull/4346) | ||
|
|
||
| - Added hash method for `RayVector`. [partial fix for issue | ||
| #2222](https://github.com/oscar-system/Oscar.jl/issues/2222) [PR | ||
| #4354](https://github.com/oscar-system/Oscar.jl/pull/4354) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's better. I've now adjusted #4396 to use this as title, and added the "use title" label.
We also should add labels reflecting the categories we use. While I am still not convinced that "Added" / "Changed" / etc. are what we want (after all the description usually makes that clear already: "Fixed a problem with ..."), I am OK with trying that out for now, we can then iterate.
But that would suggestion suitable labels. E.g.
category: change,category: fix,category: addition(or any different prefix, likekind:ortype:. Or no prefix, whatever. As long as there is a way to find out which labels are relevant. Having a common prefix simply makes that easier)