Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] More improvements #4500

Merged
merged 13 commits into from
Jan 29, 2025

Conversation

HereAround
Copy link
Member

@HereAround HereAround commented Jan 24, 2025

Changes:

  • Support family_of_g4_fluxes for a given g4-flux.
  • Bug fix and increased efficiency in D3-tadpole computation.
  • Printing of G4-flux family reflects knowledge about D3-tadpole computation.
  • Add method that checks verticality for any family of G4-fluxes.
  • Add method that checks non-abelian gauge group breaking for any family of G4-fluxes.
  • Add method that executes elementary quantization checks for any family of G4-fluxes.
  • Add arithmetics for G4-fluxes.
  • Introduce chosen_g4_flux_basis.
    This is a wrapper for ambient_space_models_of_g4_fluxes, which returns a vector of G4-fluxes instead of a vector of cohomology classes. Why? The name is shorter and easier to remember. Plus, I just added quick (!) arithmetics for G4-fluxes. So users should ideally create G4-fluxes and perform arithmetics with them, rather than with the underlying cohomology classes. Thus, have also removed the export of ambient_space_models_of_g4_fluxes, which thereby turns into an internal method. The docstrings were modified, so as to be clearer and remove any mention of this now internal method. (Aside: This change does NOT require an update of our zenodo artifact.)
  • Consolidate and improve docstring for special_flux_family.
    In particular, make the more clunky function names (e.g. _well_quantized_and_vertical_and_no_non_abelian_gauge_group_breaking_ambient_space_models_of_g4_fluxes)
    internal and clean-up the tests (fewer and more instructive tests).
  • Bug fix in forwarding properties of G4-flux families of (random) flux instances of such families.
  • Align order in which G4-fluxes and families of G4-fluxes print details: Quantization, verticality, breaking of non-abelian gauge group, tadpole.
  • Make use of the extended functionality of the attr-macro in more functions.

cc @apturner @emikelsons

@HereAround HereAround force-pushed the MoreImprovements branch 4 times, most recently from 4cba4d2 to d0bc001 Compare January 24, 2025 20:08
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 79.56204% with 28 lines in your changes missing coverage. Please review.

Project coverage is 84.53%. Comparing base (0d59f06) to head (f9d2ff4).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...al/FTheoryTools/src/FamilyOfG4Fluxes/properties.jl 69.11% 21 Missing ⚠️
...perimental/FTheoryTools/src/G4Fluxes/attributes.jl 77.77% 4 Missing ⚠️
...rimental/FTheoryTools/src/G4Fluxes/constructors.jl 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4500      +/-   ##
==========================================
- Coverage   84.55%   84.53%   -0.02%     
==========================================
  Files         672      671       -1     
  Lines       88833    88937     +104     
==========================================
+ Hits        75109    75184      +75     
- Misses      13724    13753      +29     
Files with missing lines Coverage Δ
...al/FTheoryTools/src/FamilyOfG4Fluxes/attributes.jl 80.00% <100.00%> (ø)
.../FTheoryTools/src/FamilyOfG4Fluxes/constructors.jl 78.04% <100.00%> (+1.73%) ⬆️
...ental/FTheoryTools/src/FamilyOfG4Fluxes/methods.jl 100.00% <100.00%> (ø)
...Tools/src/FamilyOfG4Fluxes/special_constructors.jl 77.41% <100.00%> (ø)
...xperimental/FTheoryTools/src/G4Fluxes/auxiliary.jl 97.04% <100.00%> (+0.01%) ⬆️
...perimental/FTheoryTools/src/G4Fluxes/properties.jl 100.00% <ø> (ø)
...heoryTools/src/Serialization/weierstrass_models.jl 45.31% <ø> (ø)
...rimental/FTheoryTools/src/G4Fluxes/constructors.jl 78.68% <83.33%> (-0.48%) ⬇️
...perimental/FTheoryTools/src/G4Fluxes/attributes.jl 80.64% <77.77%> (-1.71%) ⬇️
...al/FTheoryTools/src/FamilyOfG4Fluxes/properties.jl 69.11% <69.11%> (-30.89%) ⬇️

... and 6 files with indirect coverage changes

@HereAround HereAround force-pushed the MoreImprovements branch 12 times, most recently from 938f747 to 72bd2bc Compare January 26, 2025 22:15
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some more places where @attr could be used to streamline the control flow and enhance readability

@HereAround
Copy link
Member Author

I found some more places where @attr could be used to streamline the control flow and enhance readability

Thank you @lgoettgens. Looking into this now!

@HereAround HereAround marked this pull request as ready for review January 28, 2025 13:43
@HereAround
Copy link
Member Author

HereAround commented Jan 28, 2025

Ready for review.

@lgoettgens I have adjusted the attr-macro uses as indicated. Please take a look if you can spot more instances/if something seems off.

@apturner and @emikelsons Please take a look and let me know if you like the features/improvements. Note in particular the bug fix in the D3-tadpole computation.

Copy link
Collaborator

@emikelsons emikelsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good and the tests pass

@HereAround HereAround enabled auto-merge (squash) January 29, 2025 14:51
@HereAround HereAround merged commit e550b81 into oscar-system:master Jan 29, 2025
28 of 31 checks passed
@aaruni96 aaruni96 added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes topic: FTheoryTools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants