-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FTheoryTools] More improvements #4500
Conversation
4cba4d2
to
d0bc001
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4500 +/- ##
==========================================
- Coverage 84.55% 84.53% -0.02%
==========================================
Files 672 671 -1
Lines 88833 88937 +104
==========================================
+ Hits 75109 75184 +75
- Misses 13724 13753 +29
|
938f747
to
72bd2bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some more places where @attr
could be used to streamline the control flow and enhance readability
Thank you @lgoettgens. Looking into this now! |
…king by any flux family
…bient_space_models_of_g4_fluxes" Modifications on the corresponding docstring and removing any mention of this method in the docs
…ily and make various functions internal Bug fix in attribute setter of flux instances
Co-authored-by: Lars Göttgens <[email protected]>
bc21efc
to
f1a6f9c
Compare
Ready for review. @lgoettgens I have adjusted the attr-macro uses as indicated. Please take a look if you can spot more instances/if something seems off. @apturner and @emikelsons Please take a look and let me know if you like the features/improvements. Note in particular the bug fix in the D3-tadpole computation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good and the tests pass
Changes:
family_of_g4_fluxes
for a given g4-flux.chosen_g4_flux_basis
.This is a wrapper for
ambient_space_models_of_g4_fluxes
, which returns a vector of G4-fluxes instead of a vector of cohomology classes. Why? The name is shorter and easier to remember. Plus, I just added quick (!) arithmetics for G4-fluxes. So users should ideally create G4-fluxes and perform arithmetics with them, rather than with the underlying cohomology classes. Thus, have also removed the export ofambient_space_models_of_g4_fluxes
, which thereby turns into an internal method. The docstrings were modified, so as to be clearer and remove any mention of this now internal method. (Aside: This change does NOT require an update of our zenodo artifact.)special_flux_family
.In particular, make the more clunky function names (e.g.
_well_quantized_and_vertical_and_no_non_abelian_gauge_group_breaking_ambient_space_models_of_g4_fluxes
)internal and clean-up the tests (fewer and more instructive tests).
cc @apturner @emikelsons