[QuadFormAndIsom]: new fix, cleanup, additional improvements and better documentation #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ fix galois action + add use minpoly for equivariant primitive extensions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4546 +/- ##
==========================================
- Coverage 84.55% 84.45% -0.10%
==========================================
Files 672 672
Lines 88833 89215 +382
==========================================
+ Hits 75109 75350 +241
- Misses 13724 13865 +141
|
StevellM
commented
Feb 6, 2025
Comment on lines
+473
to
+483
| _s = sym.data | ||
| # sym.data is always a list of triples, but we also need the norm valuations | ||
| # whenever sym is dyadic and ramified. For those cases, we add it to our local symbol. | ||
| if is_dyadic(sym) && is_ramified(sym) | ||
| nn = sym.norm_val | ||
| @assert length(nn) == length(_s) | ||
| s = Tuple{Int, Int, Int, Int}[(_s[i][1], _s[i][2], _s[i][3], nn[i]) for i in 1:length(nn)] | ||
| push!(lgs_new, genus(HermLat, E, t(sym.p), s)) | ||
| else | ||
| push!(lgs_new, genus(HermLat, E, t(sym.p), _s)) | ||
| end |
There was a problem hiding this comment.
Here is the fix for _action_on_genus
StevellM
added
experimental
simonbrandhorst
approved these changes
Feb 7, 2025
| z = zero_matrix(QQ, 0, degree(cover(D))) | ||
| glue = reduce(vcat, QQMatrix[matrix(QQ, 1, degree(cover(D)), g) for g in _glue]; init=z) | ||
| glue = vcat(bAB, glue) | ||
| Fakeglue = Hecke.FakeFmpqMat(glue) |
There was a problem hiding this comment.
I believe there are some ongoing efforts on getting rid of FakeFmpqMat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_action_on_genuswhich was not working as wanted for dyadic ramified primes;equivariant_primitive_extensionsnow make use of the minimal polynomial of the isometries to be extended. This simplify the search of gluing domains, over which isometries should coincide;@reqintoreturnstatement, with trivial outputs.Then further improvements when possible, to try to reduce the number of allocations and avoid redundant computations.