Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dependabot.yml #4547

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Create dependabot.yml #4547

merged 1 commit into from
Feb 6, 2025

Conversation

ranocha
Copy link
Contributor

@ranocha ranocha commented Feb 6, 2025

Dependabot is like CompatHelper for GitHub actions. It creates PRs and bumps the versions of GitHub actions you are using. This reduces the maintenance burden, as you no longer have to develop PRs like #3902 manually.

@fingolfin
Copy link
Member

We disabled CompatHelper because it was mostly useless for us and overall caused more work than it saved.

I am sceptical about Depandabot in this regard.

@lgoettgens
Copy link
Member

lgoettgens commented Feb 6, 2025

(I think that most of the discussion here also applies to thofma/Hecke.jl#1735, Nemocas/Nemo.jl#2020, Nemocas/AbstractAlgebra.jl#1984, oscar-system/GAP.jl#1144, oscar-system/Singular.jl#851, and oscar-system/Polymake.jl#506. Let's keep it here in one place and then do appropriate actions in the other repos after we came to a conclusion here.)

From my experience with dependabot in https://github.com/JuliaTesting/Aqua.jl since last October, I must admit that I like it.

I think there are some fundamental differences between CompatHelper and dependabot or even more between Julia dependencies and github actions:

  • When a julia dependency has a breaking release, we usually have to adjust something here (aka the CompatHelper PR does not help and gets closed). Most version bumps in github actions need no manual intervention (e.g. changes in the base image, or changes in some parameters that we don't use) or only need changes outside of the code (e.g. the codecov v3->v4 change where some token had to be set in the project settings).
  • CompatHelper does only do a bump, one has to search for and look through the release notes of a dependency package manually. Compathelper prints the relevant part of the release notes directly into the PR.

I am happy to hear opinions from others.

@lgoettgens lgoettgens added the CI label Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.41%. Comparing base (3ca33ad) to head (9384fb5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4547      +/-   ##
==========================================
- Coverage   84.42%   84.41%   -0.01%     
==========================================
  Files         672      672              
  Lines       89193    89193              
==========================================
- Hits        75300    75294       -6     
- Misses      13893    13899       +6     

see 2 files with indirect coverage changes

@fingolfin
Copy link
Member

OK, if you had positive experience with @lgoettgens I am willing to give it a try and see how it behaves, we can still yank it again.

But I'll also wait to hear what e.g. @benlorenz and @thofma think.

@thofma
Copy link
Collaborator

thofma commented Feb 6, 2025

Most of the PRs in https://github.com/JuliaTesting/Aqua.jl/issues?q=is%3Apr+author%3Aapp%2Fdependabot were closed without merging. Seems to be quite labor-intensive for me for a tool that should make my life easier.

@lgoettgens
Copy link
Member

50% the PRs in JuliaTesting/Aqua.jl/pulls (is:closed dependabot) were closed without merging. Seems to be quite labor intense for me.

This was a byproduct of me trying out and learning what the different config options do. I closed these so that they get re-generated with other config options.
But what @ranocha proposes here is exactly what I ended up with as well (apart from the schedule)

@thofma
Copy link
Collaborator

thofma commented Feb 6, 2025

OK. Happy to give it a try.

@fingolfin fingolfin enabled auto-merge (squash) February 6, 2025 16:41
@fingolfin fingolfin merged commit 158a353 into oscar-system:master Feb 6, 2025
29 of 35 checks passed
@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Feb 6, 2025
@ranocha ranocha deleted the patch-2 branch February 6, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants