Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Tags in CI action for changelog #4553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

aaruni96
Copy link
Member

@aaruni96 aaruni96 commented Feb 6, 2025

Fetch Tags in CI action for changelog
[skip ci]

[skip ci]
@aaruni96
Copy link
Member Author

aaruni96 commented Feb 6, 2025

This change doesn't seem to help ( https://github.com/oscar-system/Oscar.jl/actions/runs/13184942801/job/36804728541 ). Documentation ( https://github.com/actions/checkout ) suggests this should've worked :

    # Whether to fetch tags, even if fetch-depth > 0.
    # Default: false
    fetch-tags: ''

Any ideas how to proceed @fingolfin

@fingolfin
Copy link
Member

Actually we probably don't need to fetch the tags at all. Indeed basetag is only needed as input for get_tag_date. But we can just query gh for that.

$ gh release view v1.2.2 --json=createdAt
{
  "createdAt": "2024-12-13T22:47:54Z"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants