Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a couple of bugs in the shell scripts #12

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

muzso
Copy link

@muzso muzso commented Feb 18, 2025

Some of the fixed issues:

  • variables were used as commandline arguments without being in quotes and with the possibility of containing whitespaces (where the contents of the variable would be split into multiple commandline arguments upon expansion)
  • indentation was not coherent (both tabs and spaces were used)
  • filepathes can contain whitespace characters (including newlines) and some of the scripts didn't account for this
  • build.sh failed with unbound variable if it's last commandline argument was a "--"
  • a couple of typos

Zsolt Müller added 2 commits February 18, 2025 20:04
…ent was "--", plus replaced standard "[ ... ]" conditionals with bashism
@oschonrock oschonrock merged commit 91515eb into oschonrock:main Feb 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants