Adding an expand button #62
Conversation
|
Will work on the changes and get back to you |
|
Implemented all the changes and fixes i was instructed to. |
| } else { | ||
| content.style.maxHeight = content.scrollHeight + "px"; | ||
| document.getElementById("expand").innerHTML = "⯅"; | ||
| content.style.margin = 16 + "px"; |
There was a problem hiding this comment.
You can directly put content.style.margin = "16px"; here :)
| if (content.style.maxHeight) { | ||
| document.getElementById("expand").innerHTML = "⯆"; | ||
| content.style.maxHeight = null; | ||
| content.style.margin = 0; | ||
| } else { | ||
| content.style.maxHeight = content.scrollHeight + "px"; |
There was a problem hiding this comment.
Can you explain what you are trying to do here? I'm a bit confused about what's happening here 😅
There was a problem hiding this comment.
So basically i wanted to animate the collapse/expand effect but as it turns out
So i couldn't use the transition effect on it.
So i used maxHeight property as a substitute.
When maxHeight of the collapsible is null, it will expand and the value of maxHeight will be equal to the height of the content ie ScrollHeight .
When maxHeight of the collapsible is not null, it will collapse thus taking a value of zero/null.
and then i put this in the transition property that can be found in the css file.
Hope this clears your query.
There was a problem hiding this comment.
aah, got it. Good to know. Thanks :)
|
@DragoVeizen Found some bugs during testing.
@DragoVeizen Since you haven't touched anything from |
|
Oh okay..ill check it out :) |
|
Hey, @DragoVeizen any updates on this? |
|
No not really i was investing most of my time somewhere else ill get back to this in a day or two and hopefully make it right. |
|
cool, no problem, just checking :D |
fixes #45
Button still to be customised and placed accordingly