Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

液态键盘相关修复 #1554

Merged
merged 6 commits into from
Jan 13, 2025
Merged

液态键盘相关修复 #1554

merged 6 commits into from
Jan 13, 2025

Conversation

if-can
Copy link
Contributor

@if-can if-can commented Jan 12, 2025

Pull request

可能存在与 #1548 议题的其他目录第二条相关的修复

原文如下:

2、剪贴板问题:老问题了,不赘述。

由于并未赘述问题,因此索性直接把自己遇到的有关液态键盘的问题全修了。


fix: 液态键盘符号表失效

fix: 液态键盘处于草稿或收藏标签页,在复制文本后适配器数据将更改为剪切板

fix: 剪切板更新监听,复制已存在的文本后未按预期更新数据

  • 具体现象:初次复制剪切板已存在的文本,数据不会有任何变化,再次复制已存在的文本,之前复制的内容才会移至顶部,同理下次复制,仍是更新上次复制的内容。

fix: 剪切板视图缓存存在时,复制文本后切换剪切板不会更新数据,显示新复制的内容

fix: 剪切板 item 文本颜色未跟随主题按键文本颜色

fix: 相关视图缓存销毁后,液态键盘未按预期重新生成数据

  • 复现步骤:

    1. 打开液态键盘任意标签页
    2. 切换任意输入法
    3. 切回同文并打开上次的标签页
    4. 显示的数据内容将会是空的

    问题原因:

    • 调用 select 方法切换标签页时,如果目标标签页与当前缓存视图的标签页相同,会触发 return 避免重复加载
    • 切换输入法导致视图被销毁,但应用并未完全终止运行,因此 TabManager.currentTabIndex 字段仍然保持原值。
    • 所以重建后的视图即使没有加载过数据,仍会触发 return,导致数据内容为空

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@Bambooin Bambooin merged commit 239a344 into osfans:develop Jan 13, 2025
3 checks passed
@if-can if-can deleted the fix_liquid branch January 14, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants