Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iconbtn colors #2362

Merged
merged 10 commits into from
Aug 8, 2023
Merged

Iconbtn colors #2362

merged 10 commits into from
Aug 8, 2023

Conversation

okauppinen
Copy link
Contributor

@okauppinen okauppinen commented Aug 8, 2023 •
edited
Loading

Hover color didn't work if icon has inline style color

  • Added color prop for IconButton
  • Remove antd color import and copied values to constant. Use predifened colors for delete, info, accept, reject
  • Add active (sticky) prop for IconButton like mapplugin buttons have
  • Remove DeleteIcon.jsx and use IconButton for DeleteButton icon types
  • Move disablewrapper to themebutton (also button without tooltip gets wrappper)
  • Refactor admin announcements and layeranalytics to use IconButton

<IconButton type='delete' bordered=true/false> is almost same than <DeleteButton type='icon || button'>
For IconButton confirm text is always same.

@ZakarFin ZakarFin added this to the 2.12.0 milestone Aug 8, 2023
@ZakarFin ZakarFin merged commit be0d757 into oskariorg:develop Aug 8, 2023
1 check passed
@okauppinen okauppinen mentioned this pull request Aug 11, 2023
Merged
@okauppinen okauppinen deleted the iconbtn-colors branch April 9, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakarFin ZakarFin ZakarFin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@okauppinen @ZakarFin