Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated XMLHelper with new one #987

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ZakarFin
Copy link
Member

Requires a test case

@jampukka
Copy link
Member

This should just work, no?

@ZakarFin
Copy link
Member Author

It should, but I haven't had the time to test it really :)

@ZakarFin
Copy link
Member Author

ZakarFin commented Nov 16, 2023

I removed the try/catch since any uncaught exception is caught in https://github.com/oskariorg/oskari-server/blob/master/service-control/src/main/java/fi/nls/oskari/control/ActionControl.java#L146 and that throws the same ActionException as this one and includes the cause on it or in case of an ActionException throws it as is. So the try catch is only really changing the message that is logged and I don't think we care about that as much. These will be logged here https://github.com/oskariorg/oskari-server/blob/master/servlet-map/src/main/java/fi/nls/oskari/AjaxController.java#L44-L51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants