Deposit/Withdraw fixes #3662
Deposit/Withdraw fixes #3662
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
WalkthroughRecent updates enhance how the loading state of supported assets is determined in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Component
participant API
User->>Component: Initiates loading of assets
Component->>API: Request supported assets
API-->>Component: Returns supportedAssetsResults
alt If any asset is nil or loading
Component->>User: Show loading state
else
Component->>User: Display loaded assets
end
sequenceDiagram
participant BridgeProvider
participant ErrorHandler
BridgeProvider->>ErrorHandler: Check message for route availability
alt If message includes "no single-tx routes found" or "no routes found"
ErrorHandler->>BridgeProvider: Throw BridgeQuoteError
else
ErrorHandler->>BridgeProvider: Continue processing
end
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (8)
Files skipped from review due to trivial changes (1)
Files skipped from review as they are similar to previous changes (1)
Additional comments not posted (9)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
packages/bridge/src/interface.ts (1)
15-16: Ensure allgetTimeoutHeightfunction calls match the new signatureThe following instances need to be updated to match the new function signature that expects an object with a
chainIdproperty:
packages/stores/src/account/base.ts
- Update the function call to pass an object:
const timeoutHeight = await this.getTimeoutHeight({ chainId });
packages/server/src/queries/complex/get-timeout-height.ts
- Update the function definition to accept an object:
export async function getTimeoutHeight({ chainList, chainId, }: { chainList: Chain[]; chainId: string; }): Promise<bigint> { // function body }Please make these changes to ensure consistency with the new function signature.
Analysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
getTimeoutHeightmatch the new signature.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `getTimeoutHeight` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type ts -A 5 $'getTimeoutHeight'Length of output: 9895
Script:
#!/bin/bash # Description: Verify all function calls to `getTimeoutHeight` match the new signature. # Check function calls in the identified files rg --type ts 'getTimeoutHeight\(' -A 2 packages/web/server/api/routers/bridge-transfer.ts rg --type ts 'getTimeoutHeight\(' -A 2 packages/server/src/queries/complex/get-timeout-height.ts rg --type ts 'getTimeoutHeight\(' -A 2 packages/stores/src/account/base.ts rg --type ts 'getTimeoutHeight\(' -A 2 packages/bridge/src/skip/index.ts rg --type ts 'getTimeoutHeight\(' -A 2 packages/bridge/src/squid/index.ts rg --type ts 'getTimeoutHeight\(' -A 2 packages/bridge/src/squid/__tests__/squid-bridge-provider.spec.ts rg --type ts 'getTimeoutHeight\(' -A 2 packages/bridge/src/skip/__tests__/skip-bridge-provider.spec.ts rg --type ts 'getTimeoutHeight\(' -A 2 packages/bridge/src/ibc/index.ts rg --type ts 'getTimeoutHeight\(' -A 2 packages/bridge/src/axelar/index.ts rg --type ts 'getTimeoutHeight\(' -A 2 packages/bridge/src/axelar/__tests__/axelar-bridge-provider.spec.ts rg --type ts 'getTimeoutHeight\(' -A 2 packages/bridge/src/ibc/__tests__/ibc-bridge-provider.spec.tsLength of output: 2195
Script:
#!/bin/bash # Description: Verify all function calls to `getTimeoutHeight` match the new signature in specific files. # Check function calls in the identified files rg --type ts 'getTimeoutHeight\(' -A 2 packages/stores/src/account/base.ts rg --type ts 'getTimeoutHeight\(' -A 2 packages/server/src/queries/complex/get-timeout-height.tsLength of output: 516
What is the purpose of the change: