-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit Orders and Swap Flow Redesign #3683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes feat: order history page improvements
…/osmosis-frontend into fabryscript/implement-final-redesigns
[Limit Orders]: Input Quantity Fix
…flag [Limit Orders - V3]: Swap Tool Feature Flags
DavideSegullo
approved these changes
Aug 7, 2024
jonator
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change:
These changes are to introduce several new features:
A large amount of changes are in the following components:
trade-tool/index.tsx
place-limit-tool/index.tsx
orders-history/index.tsx
swap-tool/alt.tsx
The majority of the logic is performed by the new
usePlaceLimit
hook which maintains both state for limit and market orders and swaps between them.A new edge router was added,
orderbook-router
, specifically for orderbooks that includes queries to fetch orderbook metadata and order data (including historical data).