Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Limit Orders - V3]: Allow Placing Limits Other Side of Market #3685

Merged

Conversation

crnbarr93
Copy link
Contributor

What is the purpose of the change:

These changes allow a user to place a limit order on the opposite side of the current market price. A warning is displayed to the user in various places before the order is placed.

Brief Changelog

  • usePlaceLimit.isMarket now only uses current order type
  • Added warnings to review order modal for placing limit on opposite side of market price
  • Fixed review order bug with percentage display

@crnbarr93 crnbarr93 requested a review from DavideSegullo August 6, 2024 17:13
Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 5:18pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
osmosis-frontend-datadog ⬜️ Ignored (Inspect) Aug 6, 2024 5:18pm
osmosis-frontend-dev ⬜️ Ignored (Inspect) Aug 6, 2024 5:18pm
osmosis-frontend-edgenet ⬜️ Ignored (Inspect) Aug 6, 2024 5:18pm
osmosis-testnet ⬜️ Ignored (Inspect) Aug 6, 2024 5:18pm

@crnbarr93 crnbarr93 merged commit 37001d7 into feat/implement-limit-orders Aug 6, 2024
25 of 29 checks passed
@crnbarr93 crnbarr93 deleted the connor/disable-auto-market-order branch August 6, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants