Mattupham/fe 944 portfolio add chart expand minimize #3703

mattupham · 2024-08-08T05:36:53Z

What is the purpose of the change:

Add chart minimzation / transitions

Linear Task

Brief Changelog

add transitions for chart
add minimzed chart
reset chart styles to neutral
clean up layout

note - a handful of design side changes to the mini chart and portfolio performance as well

Testing and Verifying

chart.transitions.mov

vercel · 2024-08-08T05:36:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 9, 2024 5:47am

4 Skipped Deployments

Name	Status	Preview	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)	Visit Preview	Aug 9, 2024 5:47am
osmosis-frontend-dev	⬜️ Ignored (Inspect)	Visit Preview	Aug 9, 2024 5:47am
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)		Aug 9, 2024 5:47am
osmosis-testnet	⬜️ Ignored (Inspect)	Visit Preview	Aug 9, 2024 5:47am

coderabbitai · 2024-08-08T05:37:01Z

Walkthrough

The recent updates enhance the configurability and interactivity of chart components within the application. Key features include optional properties for controlling scale visibility, the introduction of a minimized chart view with refined state management, and streamlined rendering logic for improved responsiveness. These changes collectively boost user experience and maintainability across chart-related components, enabling smoother interactions and more flexible layouts.

Changes

Files	Change Summary
`packages/web/components/chart/historical-chart.tsx`	Added `showScales` and `hideScales` properties for controlling scale visibility; updated rendering logic accordingly.
`packages/web/components/complex/portfolio/historical-chart.tsx`, `packages/web/components/complex/portfolio/assets-overview.tsx`	Refactored to use dedicated props interfaces; introduced a minimized chart view and streamlined rendering logic.
`packages/web/components/complex/portfolio/portfolio-page.tsx`	Removed `RecentTransfers` component for a simplified interface; adjusted class names for improved styling.
`packages/web/components/assets/highlights-categories.tsx`, `packages/web/components/assets/price.tsx`, `packages/web/components/table/asset-info.tsx`	Enhanced styling through the addition and removal of specific classes in several components.
`packages/web/components/complex/portfolio/user-positions.tsx`, `packages/web/components/table/asset-balances.tsx`	Updated classes in section and layout components for better styling and layout improvements.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 23035fa and 042dda9.

Files selected for processing (1)

packages/web/components/complex/portfolio/assets-overview.tsx (4 hunks)

Additional context used

Biome

packages/web/components/complex/portfolio/assets-overview.tsx

[error] 141-141: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 206-206: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

Additional comments not posted (3)

packages/web/components/complex/portfolio/assets-overview.tsx (3)
Line range hint 1-21:
Imports are well-structured.

The imports correctly include new components for chart transitions and state management, aligning with the PR objectives.

127-129: State management for chart visibility is clear.

The addition of isChartMinimized and setIsChartMinimized aligns with the objective of managing chart visibility effectively.

132-276: Rendering logic for chart transitions is well-structured.

The use of Transition for smooth transitions between minimized and expanded chart states is effective and aligns with the PR objectives.

Consider using optional chaining for safety.

Optional chaining can prevent runtime errors when accessing properties of potentially undefined objects. This suggestion was previously made and remains valid.
- disabled={totalValue && totalValue.toDec().isZero()}
+ disabled={totalValue?.toDec().isZero()}
- const totalDisplayValue = new PricePretty(DEFAULT_VS_CURRENCY, new Dec(dataPoint.value || 0)) || totalValue?.toString();
+ const totalDisplayValue = new PricePretty(DEFAULT_VS_CURRENCY, new Dec(dataPoint.value || 0)) || totalValue?.toString();
Tools

Biome

[error] 141-141: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 206-206: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

mergify · 2024-08-08T05:37:31Z

⚠️ The sha of the head commit of this PR conflicts with #3701. Mergify cannot evaluate rules on this PR. ⚠️

mergify · 2024-08-08T05:38:37Z

⚠️ The sha of the head commit of this PR conflicts with #3701. Mergify cannot evaluate rules on this PR. ⚠️

…-minimize

coderabbitai

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (2)

packages/web/components/complex/portfolio/assets-overview.tsx (2)
142-142: Consider using optional chaining.

Consider using optional chaining to simplify the expression and handle potential undefined values safely.
- {wallet && wallet.isWalletConnected && wallet.address ? (
+ {wallet?.isWalletConnected && wallet.address ? (
Tools

Biome

[error] 142-142: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

207-207: Consider using optional chaining.

Consider using optional chaining to simplify the expression and handle potential undefined values safely.
- disabled={totalValue && totalValue.toDec().isZero()}
+ disabled={totalValue?.toDec().isZero()}
Tools

Biome

[error] 207-207: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

coderabbitai

Actionable comments posted: 2

packages/web/components/complex/portfolio/assets-overview.tsx

…-minimize

mattupham added 9 commits August 7, 2024 18:22

preserveAspectRatio

e99083b

Get animations working

f8472aa

Clean up with ref

435ba01

Handle show scales

b4a8b71

add button to minimize

1b1d0da

Add transition

5a19a1e

Add hover state

a1f7bc0

Add card

05be302

Clean up

f89adaf

mattupham marked this pull request as draft August 8, 2024 05:37

mattupham changed the title ~~Mattupham/fe 944 portfolio add chart expand minimize~~ [draft] Mattupham/fe 944 portfolio add chart expand minimize Aug 8, 2024

vercel bot had a problem deploying to Preview – osmosis-frontend August 8, 2024 05:39 Failure

Merge branch 'stage' into mattupham/fe-944-portfolio-add-chart-expand…

18d6c2b

…-minimize

coderabbitai bot reviewed Aug 8, 2024

View reviewed changes

mattupham added 2 commits August 7, 2024 22:47

Add optional skeleton

d57825b

Update chart style

249bc64

vercel bot had a problem deploying to Preview – osmosis-frontend August 8, 2024 16:11 Failure

mattupham added 3 commits August 8, 2024 12:03

Merge with stage

abc30ee

Update transitions

040eb53

Clean up

f045ff2

vercel bot had a problem deploying to Preview – osmosis-frontend August 8, 2024 21:34 Failure

mattupham added 5 commits August 8, 2024 14:39

udpates

70020ba

migrate portfolio performance

4dcc033

Clean up globals

8d6405c

Add transitions

3d927b5

Update expand area

9d486ee

mattupham added 7 commits August 8, 2024 15:47

add transitions

007783a

Clean up

e2f04eb

Make chart not selectable

492f523

Fix fit

0329da6

Clean up

c499fb4

Clean up chart minimization

e262910

Clean up scales

fee8c56

vercel bot had a problem deploying to Preview – osmosis-frontend August 9, 2024 00:08 Failure

mattupham added 2 commits August 8, 2024 17:09

Clean up config

1256615

Cleanup

f2a4629

vercel bot had a problem deploying to Preview – osmosis-frontend August 9, 2024 00:15 Failure

mattupham added 2 commits August 8, 2024 17:16

Clean up ref

e42da54

Clean up

c807961

mattupham requested a review from a team August 9, 2024 00:20

mattupham changed the title ~~[draft] Mattupham/fe 944 portfolio add chart expand minimize~~ Mattupham/fe 944 portfolio add chart expand minimize Aug 9, 2024

mattupham marked this pull request as ready for review August 9, 2024 00:20

vercel bot had a problem deploying to Preview – osmosis-frontend August 9, 2024 00:21 Failure

Clean up i18n

c0c8d3b

coderabbitai bot reviewed Aug 9, 2024

View reviewed changes

packages/web/components/complex/portfolio/assets-overview.tsx Show resolved Hide resolved

packages/web/components/complex/portfolio/assets-overview.tsx Show resolved Hide resolved

vercel bot had a problem deploying to Preview – osmosis-frontend August 9, 2024 00:27 Failure

mattupham added 2 commits August 8, 2024 21:20

Fix coins

73404cc

Merge branch 'stage' into mattupham/fe-944-portfolio-add-chart-expand…

420a479

…-minimize

vercel bot had a problem deploying to Preview – osmosis-frontend August 9, 2024 04:27 Failure

Fix import

23035fa

vercel bot had a problem deploying to Preview – osmosis-frontend August 9, 2024 04:55 Failure

Remove extra state

042dda9

vercel bot deployed to Preview – osmosis-frontend August 9, 2024 05:47 View deployment

jonator approved these changes Aug 9, 2024

View reviewed changes

mattupham merged commit 64943c6 into stage Aug 9, 2024
31 checks passed

mattupham deleted the mattupham/fe-944-portfolio-add-chart-expand-minimize branch August 9, 2024 15:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mattupham/fe 944 portfolio add chart expand minimize #3703

Mattupham/fe 944 portfolio add chart expand minimize #3703

mattupham commented Aug 8, 2024 •

edited

Loading

vercel bot commented Aug 8, 2024 •

edited

Loading

coderabbitai bot commented Aug 8, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

mergify bot commented Aug 8, 2024

mergify bot commented Aug 8, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

Mattupham/fe 944 portfolio add chart expand minimize #3703

Mattupham/fe 944 portfolio add chart expand minimize #3703

Conversation

mattupham commented Aug 8, 2024 • edited Loading

What is the purpose of the change:

Linear Task

Brief Changelog

Testing and Verifying

vercel bot commented Aug 8, 2024 • edited Loading

coderabbitai bot commented Aug 8, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

mergify bot commented Aug 8, 2024

mergify bot commented Aug 8, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

mattupham commented Aug 8, 2024 •

edited

Loading

vercel bot commented Aug 8, 2024 •

edited

Loading

coderabbitai bot commented Aug 8, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)